Re: [PATCH 1/5][KERNEL] meta: add usb/host/base feature

[Darren Hart <dvhart@linux.intel.com>]

On 05/02/2012 08:35 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Add a feature to enable 'base' support for USB, mainly to be included
> by derived features such as ehch, xhci, etc.

This seems overly granular in my opinion. I think I would just include
the two required options in each of the *hci features.

--
Darren

> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> ---
>  meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
>  meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
>  2 files changed, 7 insertions(+), 0 deletions(-)
>  create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
> 
> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.cfg b/meta/cfg/kernel-cache/features/usb/host/base.cfg
> new file mode 100644
> index 0000000..dec6a47
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/usb/host/base.cfg
> @@ -0,0 +1,3 @@
> +CONFIG_USB_SUPPORT=y
> +CONFIG_USB=y
> +
> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.scc b/meta/cfg/kernel-cache/features/usb/host/base.scc
> new file mode 100644
> index 0000000..3c93475
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/usb/host/base.scc
> @@ -0,0 +1,4 @@
> +define KFEATURE_DESCRIPTION "Enable core options for USB support"
> +define KFEATURE_COMPATIBILITY board
> +
> +kconf hardware base.cfg

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel