Re: [PATCH] x86: make the dom0_max_vcpus option more flexible

[David Vrabel <david.vrabel@citrix.com>]

On 04/05/12 17:12, Jan Beulich wrote:
>>>> On 04.05.12 at 18:01, David Vrabel <david.vrabel@citrix.com> wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> The dom0_max_vcpus command line option only allows the exact number of
>> VCPUs for dom0 to be set.  It is not possible to say "up to N VCPUs
>> but no more than the number physically present."
>>
>> Add min: and max: prefixes to the option to set a minimum number of
>> VCPUs, and a maximum which does not exceed the number of PCPUs.
>>
>> For example, with "dom0_max_vcpus=min:4,max:8":
> 
> Both "...max...=min:..." and "...max...=max:" look pretty odd to me;
> how about simply allowing a range along with a simple number (since
> negative values make no sense, omitting either side of the range would
> be supportable if necessary.

I was copying the way dom0_mem worked but yeah, it's not very pretty.

Is dom0_max_vcpus=<min>-<max> (e.g., dom0_max_vcpus=4-8)  what you were
thinking of?

Using a single value would have to set both <min> and <max> or the
behaviour of the option changes (i.e., =N is the same as =N-N).

David