From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4FA4041D.9010000@ti.com> Date: Fri, 4 May 2012 11:30:21 -0500 From: Jon Hunter MIME-Version: 1.0 To: "Mohammed, Afzal" Subject: Re: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD References: <4FA04A8C.4050703@ti.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: "Hilman, Kevin" , "Menon, Nishanth" , "linux@arm.linux.org.uk" , "tony@atomide.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "Balbi, Felipe" , "dbaryshkov@gmail.com" , "kyungmin.park@samsung.com" , "vimal.newwork@gmail.com" , "grinberg@compulab.co.il" , "artem.bityutskiy@linux.intel.com" , "linux-mtd@lists.infradead.org" , "linux-omap@vger.kernel.org" , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" , "notasas@gmail.com" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Afzal, On 05/03/2012 03:37 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Wed, May 02, 2012 at 02:11:48, Hunter, Jon wrote: >>> + >>> + pdata->clk_prd = gpmc_get_fclk_period(); >> >> Does this need to be done here? May be this should be done in the probe >> function. You could store the handle to the main clk in the pdata. > > This is done so that migration of gpmc driver to the drivers folder > would be smooth, remember that this function will still live here. Sure, but why call this here? >>> + pr_err("error: clk_get on %s\n", oh->main_clk); >>> + return -EINVAL; >>> } >>> >>> clk_enable(gpmc_l3_clk); >> >> I would have thought we should be able to remove the gpmc_init function >> completely by now. Most of the code should be moved to the probe function. >> >> Also now with hwmod in place, we should be able to remove the >> clk_enable/disable functions and use the pm_runtime APIs instead. > > There was no plan to add rpm in this series, but now that you have > brought it up, I will adapt the driver to rpm. Ok, great. Jon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD Date: Fri, 4 May 2012 11:30:21 -0500 Message-ID: <4FA4041D.9010000@ti.com> References: <4FA04A8C.4050703@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:57782 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182Ab2EDQai (ORCPT ); Fri, 4 May 2012 12:30:38 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Mohammed, Afzal" Cc: "tony@atomide.com" , "linux@arm.linux.org.uk" , "Hilman, Kevin" , "Balbi, Felipe" , "dwmw2@infradead.org" , "kyungmin.park@samsung.com" , "gregkh@linuxfoundation.org" , "Menon, Nishanth" , "grinberg@compulab.co.il" , "notasas@gmail.com" , "artem.bityutskiy@linux.intel.com" , "vimal.newwork@gmail.com" , "dbaryshkov@gmail.com" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" , "linux-mtd@lists.infradead.org" Hi Afzal, On 05/03/2012 03:37 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Wed, May 02, 2012 at 02:11:48, Hunter, Jon wrote: >>> + >>> + pdata->clk_prd = gpmc_get_fclk_period(); >> >> Does this need to be done here? May be this should be done in the probe >> function. You could store the handle to the main clk in the pdata. > > This is done so that migration of gpmc driver to the drivers folder > would be smooth, remember that this function will still live here. Sure, but why call this here? >>> + pr_err("error: clk_get on %s\n", oh->main_clk); >>> + return -EINVAL; >>> } >>> >>> clk_enable(gpmc_l3_clk); >> >> I would have thought we should be able to remove the gpmc_init function >> completely by now. Most of the code should be moved to the probe function. >> >> Also now with hwmod in place, we should be able to remove the >> clk_enable/disable functions and use the pm_runtime APIs instead. > > There was no plan to add rpm in this series, but now that you have > brought it up, I will adapt the driver to rpm. Ok, great. Jon From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon-hunter@ti.com (Jon Hunter) Date: Fri, 4 May 2012 11:30:21 -0500 Subject: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD In-Reply-To: References: <4FA04A8C.4050703@ti.com> Message-ID: <4FA4041D.9010000@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Afzal, On 05/03/2012 03:37 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Wed, May 02, 2012 at 02:11:48, Hunter, Jon wrote: >>> + >>> + pdata->clk_prd = gpmc_get_fclk_period(); >> >> Does this need to be done here? May be this should be done in the probe >> function. You could store the handle to the main clk in the pdata. > > This is done so that migration of gpmc driver to the drivers folder > would be smooth, remember that this function will still live here. Sure, but why call this here? >>> + pr_err("error: clk_get on %s\n", oh->main_clk); >>> + return -EINVAL; >>> } >>> >>> clk_enable(gpmc_l3_clk); >> >> I would have thought we should be able to remove the gpmc_init function >> completely by now. Most of the code should be moved to the probe function. >> >> Also now with hwmod in place, we should be able to remove the >> clk_enable/disable functions and use the pm_runtime APIs instead. > > There was no plan to add rpm in this series, but now that you have > brought it up, I will adapt the driver to rpm. Ok, great. Jon