From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60967)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SQLQZ-0006p3-DH
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:32:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SQLQX-0006iM-J3
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:32:18 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:43795)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SQLQX-0006iG-CL
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:32:17 -0400
Message-ID: <4FA4048F.3080705@weilnetz.de>
Date: Fri, 04 May 2012 18:32:15 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1336121154-26517-1-git-send-email-pbonzini@redhat.com>
	<1336121154-26517-8-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1336121154-26517-8-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/14] scsi-disk: add dpofua property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Am 04.05.2012 10:45, schrieb Paolo Bonzini:
> Linux expects REQ_FUA to be advertised only if WRITE+FUA is faster than
> WRITE+SYNCHRONIZE CACHE, so we should not set the DPOFUA bit.  However,
> it is useful to have it for testing purposes, so add a qdev property to
> set it.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   hw/scsi-disk.c |    7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index e04b469..e0f1821 100644
> --- a/hw/scsi-disk.c
> +++ b/hw/scsi-disk.c
> @@ -62,6 +62,7 @@ typedef struct SCSIDiskReq {
>   } SCSIDiskReq;
>
>   #define SCSI_DISK_F_REMOVABLE	0
> +#define SCSI_DISK_F_DPOFUA	1
>
>

ERROR: code indent should never use tabs
#24: FILE: hw/scsi-disk.c:65:
+#define SCSI_DISK_F_DPOFUA^I1$

total: 1 errors, 0 warnings, 31 lines checked

0007-scsi-disk-add-dpofua-property.patch has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.