From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 00847E006C7 for ; Fri, 4 May 2012 09:34:50 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 04 May 2012 09:34:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,351,1309762800"; d="scan'208";a="140161524" Received: from unknown (HELO envy.home) ([10.255.12.74]) by orsmga002.jf.intel.com with ESMTP; 04 May 2012 09:34:50 -0700 Message-ID: <4FA4050C.4080607@linux.intel.com> Date: Fri, 04 May 2012 09:34:20 -0700 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120424 Thunderbird/12.0 MIME-Version: 1.0 To: Tom Zanussi References: <5c329be00981f6c931bd192bf5af741fb7da4a81.1336015630.git.tom.zanussi@intel.com> <4FA400FA.9030903@linux.intel.com> <1336148918.21923.4.camel@elmorro> In-Reply-To: <1336148918.21923.4.camel@elmorro> X-Enigmail-Version: 1.4.1 Cc: yocto@yoctoproject.org Subject: Re: [PATCH 1/5][KERNEL] meta: add usb/host/base feature X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2012 16:34:51 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/04/2012 09:28 AM, Tom Zanussi wrote: > On Fri, 2012-05-04 at 09:16 -0700, Darren Hart wrote: >> >> On 05/02/2012 08:35 PM, tom.zanussi@intel.com wrote: >>> From: Tom Zanussi >>> >>> Add a feature to enable 'base' support for USB, mainly to be included >>> by derived features such as ehch, xhci, etc. >> >> This seems overly granular in my opinion. I think I would just include >> the two required options in each of the *hci features. >> > > Really? This seems to me a perfect use case for taking advantage of the > 'reusibality' conf fragments offer. There would be four of these, that > alone would seem to justify using a 'subroutine', but there could be > more in the future, and if so, this fragment would be readily available. > I agree in principle, but feel the two lines of obvious requirements aren't worth it. > i.e. I don't see any reason to 'inline' these... I think "the line" is obviously a subjective one. And since you are the one that put in the time to prepare the meta-data, I don't feel strongly enough about it to argue the point. So I won't object to them going in as is. -- Darren > > Tom > >> -- >> Darren >> >>> >>> Signed-off-by: Tom Zanussi >>> --- >>> meta/cfg/kernel-cache/features/usb/host/base.cfg | 3 +++ >>> meta/cfg/kernel-cache/features/usb/host/base.scc | 4 ++++ >>> 2 files changed, 7 insertions(+), 0 deletions(-) >>> create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg >>> create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc >>> >>> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.cfg b/meta/cfg/kernel-cache/features/usb/host/base.cfg >>> new file mode 100644 >>> index 0000000..dec6a47 >>> --- /dev/null >>> +++ b/meta/cfg/kernel-cache/features/usb/host/base.cfg >>> @@ -0,0 +1,3 @@ >>> +CONFIG_USB_SUPPORT=y >>> +CONFIG_USB=y >>> + >>> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.scc b/meta/cfg/kernel-cache/features/usb/host/base.scc >>> new file mode 100644 >>> index 0000000..3c93475 >>> --- /dev/null >>> +++ b/meta/cfg/kernel-cache/features/usb/host/base.scc >>> @@ -0,0 +1,4 @@ >>> +define KFEATURE_DESCRIPTION "Enable core options for USB support" >>> +define KFEATURE_COMPATIBILITY board >>> + >>> +kconf hardware base.cfg >> > > -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel