From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLjQ-0006Mt-2j for qemu-devel@nongnu.org; Fri, 04 May 2012 12:51:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQLjN-0006QX-GU for qemu-devel@nongnu.org; Fri, 04 May 2012 12:51:47 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:49682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLjN-0006QH-A2 for qemu-devel@nongnu.org; Fri, 04 May 2012 12:51:45 -0400 Message-ID: <4FA4091F.3010001@weilnetz.de> Date: Fri, 04 May 2012 18:51:43 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1336121154-26517-1-git-send-email-pbonzini@redhat.com> <1336121154-26517-3-git-send-email-pbonzini@redhat.com> <4FA403BD.2050309@weilnetz.de> <4FA403F6.4070506@redhat.com> In-Reply-To: <4FA403F6.4070506@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 04.05.2012 18:29, schrieb Paolo Bonzini: > Il 04/05/2012 18:28, Stefan Weil ha scritto: >>> - !(buf[0] == REQUEST_SENSE&& d->sense_is_ua))) { + if (cmd.xfer> >>> INT32_MAX) { + req = scsi_req_alloc(&reqops_invalid_field, d, tag, >>> lun, hba_private); >> WARNING: line over 80 characters #54: FILE: hw/scsi-bus.c:533: + req >> = scsi_req_alloc(&reqops_invalid_field, d, tag, lun, hba_private); >> total: 0 errors, 1 warnings, 50 lines checked >> 0002-scsi-prevent-data-transfer-overflow.patch has style problems, >> please review. If any of these errors are false positives report them >> to the maintainer, see CHECKPATCH in MAINTAINERS. > It's a warning for a reason... Paolo That's ok. It was just funny that a patch which prevents data transfer overflow introduces a line overflow :-) The tabs in patches 6 and 7 are more problematic. Although they are not at the start of the line, tabs should be completely avoided (that's my personal understanding of QEMU's coding rules). Existing code which violates that rule is no reason to add more code with tabs. Exceptions should be possible for code imported from other projects, maybe also when existing code with tabs is extended. But what is even more important than those tabs is getting the fixes in qemu 1.1. I pulled them just to see whether my scsi problem was fixed, and it's git and checkpatch.pl which complains, not me :-) Cheers, Stefan