From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: fix gen4 gpu reset
Date: Fri, 04 May 2012 14:06:29 -0300 [thread overview]
Message-ID: <4FA40C95.8060400@linux.intel.com> (raw)
In-Reply-To: <1335987232-4786-1-git-send-email-daniel.vetter@ffwll.ch>
On 05/02/2012 04:33 PM, Daniel Vetter wrote:
> While trying to fix up gen4 gpu reset in
>
> commit f49f0586191fe16140410db0a46d43bdc690d6af
> Author: Kenneth Graunke<kenneth@whitecape.org>
> Date: Sat Sep 11 01:19:14 2010 -0700
>
> drm/i915: Actually set the reset bit in i965_reset
>
> a little confusion about when wait_for times out has been introduced -
> wait for loops _until_ the condition is true.
>
> This fixes gpu reset on my gm45, testing with my hangman code shows
> that it's now fairly reliable - it only died after well over 100 reset
> cycles.
>
> Cc: Kenneth Graunke<kenneth@whitecape.org>
> Cc: Eric Anholt<eric@anholt.net>
> Signed-Off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
I haven't tested it on a real machine to verify if it actually does the
reset, but this change does explains why it could not work before :).
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
next prev parent reply other threads:[~2012-05-04 17:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 13:17 [PATCH 01/10] drm/i915: add interface to simulate gpu hangs Daniel Vetter
2012-04-27 13:17 ` [PATCH 02/10] drm/i915: rework dev->first_error locking Daniel Vetter
2012-05-04 17:04 ` Eugeni Dodonov
2012-04-27 13:17 ` [PATCH 03/10] drm/i915: allow the existing error_state to be destroyed Daniel Vetter
2012-05-04 11:56 ` Daniel Vetter
2012-05-04 17:15 ` Eugeni Dodonov
2012-05-04 19:58 ` Daniel Vetter
2012-04-27 13:17 ` [PATCH 04/10] drm/i915: simplify i915_reset a bit Daniel Vetter
2012-05-04 16:47 ` Eugeni Dodonov
2012-04-27 13:17 ` [PATCH 05/10] drm/i915: extract intel_gpu_reset Daniel Vetter
2012-04-30 1:03 ` Ben Widawsky
2012-05-04 16:51 ` Eugeni Dodonov
2012-04-27 13:17 ` [PATCH 06/10] drm/i915: make gpu hangman more resilient Daniel Vetter
2012-05-04 16:47 ` Eugeni Dodonov
2012-04-27 13:17 ` [PATCH 07/10] drm/i915: kill flags parameter for reset functions Daniel Vetter
2012-05-04 16:47 ` Eugeni Dodonov
2012-04-27 13:17 ` [PATCH 08/10] drm/i915: also reset the media engine on gen4/5 Daniel Vetter
2012-04-27 13:17 ` [PATCH 09/10] drm/i915: remove modeset reset from i915_reset Daniel Vetter
2012-04-27 13:17 ` [PATCH 10/10] drm/i915: kill gen4 gpu reset code Daniel Vetter
2012-04-27 18:49 ` Eric Anholt
2012-04-27 19:17 ` Daniel Vetter
2012-04-27 23:26 ` Eric Anholt
2012-05-02 19:33 ` [PATCH] drm/i915: fix gen4 gpu reset Daniel Vetter
2012-05-02 19:54 ` Kenneth Graunke
2012-05-04 12:07 ` Daniel Vetter
2012-05-04 17:06 ` Eugeni Dodonov [this message]
2012-04-28 4:56 ` [PATCH 01/10] drm/i915: add interface to simulate gpu hangs Ben Widawsky
2012-05-02 15:23 ` Daniel Vetter
2012-05-03 12:48 ` [PATCH] " Daniel Vetter
2012-05-03 19:00 ` Eugeni Dodonov
2012-05-05 19:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA40C95.8060400@linux.intel.com \
--to=eugeni.dodonov@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.