From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 3/3] Make scsi_free_queue() abort pending requests
Date: Sat, 05 May 2012 06:07:58 +0000
Message-ID: <4FA4C3BE.1080505@acm.org>
References: <4FA3EF10.3040104@acm.org> <4FA3F0B1.9040207@acm.org> <4FA43B21.2060906@cs.wisc.edu> <4FA43CC3.6040507@cs.wisc.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <linux-scsi-owner@vger.kernel.org>
Received: from relay03ant.iops.be ([212.53.5.218]:46462 "EHLO
	relay03ant.iops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752191Ab2EEGIL (ORCPT
	<rfc822;linux-scsi@vger.kernel.org>); Sat, 5 May 2012 02:08:11 -0400
In-Reply-To: <4FA43CC3.6040507@cs.wisc.edu>
Sender: linux-scsi-owner@vger.kernel.org
List-Id: linux-scsi@vger.kernel.org
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: linux-scsi <linux-scsi@vger.kernel.org>, James Bottomley <jbottomley@parallels.com>, Jun'ichi Nomura <j-nomura@ce.jp.nec.com>, Stefan Richter <stefanr@s5r6.in-berlin.de>, Tomas Henzl <thenzl@redhat.com>, Mike Snitzer <snitzer@redhat.com>

On 05/04/12 20:32, Mike Christie wrote:

> Oh not wait. I do not get the patch. After blk_cleanup_queue runs then
> no IO should be running and no new IO can be queued can it?
> 
>>>  	 */
>>>  	blk_cleanup_queue(q);
>>> +	blk_abort_queue(q);
>>>  
>>>  	if (sdev->is_visible) {
>>>  		if (scsi_device_set_state(sdev, SDEV_CANCEL) != 0)


After blk_cleanup_queue() finished no new requests will be queued to a
SCSI LLD. However, that function doesn't wait for already queued
requests to finish. I have verified with ib_srp LLD that the
blk_abort_queue() call triggers the "SRP abort called" kernel log
message generated by ib_srp when srp_abort() is called.

Bart.