From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
"Keir (Xen.org)" <keir@xen.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [xen-unstable test] 11946: regressions - FAIL
Date: Sat, 5 May 2012 12:11:45 +0100 [thread overview]
Message-ID: <4FA50AF1.8010608@citrix.com> (raw)
In-Reply-To: <1336214027.3735.16.camel@dagon.hellion.org.uk>
>> The attached patch should prevent this panic
> This is effectively the same as my patch from
> <1332844592.25560.9.camel@zakaz.uk.xensource.com>. I think "if (ssid)
> xfree(...)" is preferable to "if (in_irq()) xfree(...)" but not enough
> to prevent me:
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> If the debug code is going to stay for 4.2 then IMHO we should also take
> this patch to make it actually useful. Otherwise we should just revert
> the original debug patch before the release.
>
>
Yes - I was thinking the same. I suggest that when xen-4.2-testing.hg
gets branched off unstable, this debugging gets put back to just being
an assert as before. However, I am quite unsure as to what would happen
with interrupts following that failed assert.
I shall re-do the patch. I think it is a fairly sensible patch to have
in even after the main debugging has been removed, especially if similar
debugging needs to be done in the future.
~Andrew
prev parent reply other threads:[~2012-05-05 11:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 20:16 [xen-unstable test] 11946: regressions - FAIL xen.org
2012-02-14 10:44 ` Ian Campbell
2012-02-14 19:17 ` Daniel De Graaf
2012-03-27 10:36 ` Ian Campbell
2012-03-27 10:52 ` Jan Beulich
2012-05-04 19:48 ` AP
2012-05-04 20:11 ` Andrew Cooper
2012-05-05 0:21 ` AP
2012-05-05 11:04 ` Andrew Cooper
2012-05-05 18:41 ` AP
2012-05-05 19:06 ` AP
2012-05-07 8:10 ` Jan Beulich
2012-05-07 11:50 ` Andrew Cooper
2012-05-07 13:34 ` Jan Beulich
2012-05-07 14:41 ` Andrew Cooper
2012-05-07 14:50 ` Jan Beulich
2012-05-07 15:40 ` Andrew Cooper
2012-05-07 15:43 ` Jan Beulich
2012-05-07 14:54 ` Jan Beulich
2012-05-07 15:51 ` Andrew Cooper
2012-05-07 18:29 ` AP
2012-05-08 6:37 ` Jan Beulich
2012-05-05 10:33 ` Ian Campbell
2012-05-05 11:11 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA50AF1.8010608@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.