From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:16716 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446Ab2EEOqf (ORCPT ); Sat, 5 May 2012 10:46:35 -0400 Message-ID: <4FA53D48.6020004@redhat.com> Date: Sat, 05 May 2012 16:46:32 +0200 From: Hans de Goede MIME-Version: 1.0 To: Hans Verkuil CC: linux-media@vger.kernel.org, Jean-Francois Moine , Hans Verkuil Subject: Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework. References: <1335625796-9429-1-git-send-email-hverkuil@xs4all.nl> <4FA4DA05.5030001@redhat.com> <201205051034.30484.hverkuil@xs4all.nl> In-Reply-To: <201205051034.30484.hverkuil@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi, On 05/05/2012 10:34 AM, Hans Verkuil wrote: > On Sat May 5 2012 09:43:01 Hans de Goede wrote: >> Hi, >> >> I'm slowly working my way though this series today (both review, as well >> as some tweaks and testing). > > Thanks for that! > > One note: I initialized the controls in sd_init. That's wrong, it should be > sd_config. sd_init is also called on resume, so that would initialize the > controls twice. You cannot move the initializing of the controls to sd_config, since in many cases the sensor probing is done in sd_init, and we need to know the sensor type to init the controls. I suggest that instead you give the sd_init function a resume parameter and only init the controls if the resume parameter is false. > I'm working on this as well today, together with finishing the stv06xx and > mars conversion. Cool! Regards, Hans