From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: X86: Add mmx movq emulation
Date: Sun, 06 May 2012 13:08:05 +0300 [thread overview]
Message-ID: <4FA64D85.1000609@redhat.com> (raw)
In-Reply-To: <1336132029-13523-1-git-send-email-joerg.roedel@amd.com>
On 05/04/2012 02:47 PM, Joerg Roedel wrote:
> Add support to the MMX versions of the movq instructions to
> the instruction emulator. Also handle possible exceptions
> they may cause.
This is already in (cbe2c9d30, e59717550e). Are you looking at master
instead of next?
Since you've just thought of the issues involved, I'd appreciate a
review of the commits above, both wrt correctness and maintainability.
In fact I already see one difference - my patches do reg &= 7, while
your patches generate #UD for %mm8-%mm15.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-05-06 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 11:47 [PATCH] KVM: X86: Add mmx movq emulation Joerg Roedel
2012-05-06 10:08 ` Avi Kivity [this message]
2012-05-07 8:56 ` Joerg Roedel
2012-05-07 9:08 ` Avi Kivity
2012-05-07 10:28 ` Joerg Roedel
2012-05-07 10:30 ` Avi Kivity
2012-05-07 10:44 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA64D85.1000609@redhat.com \
--to=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.