From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
g.liakhovetski@gmx.de, hdegoede@redhat.com, moinejf@free.fr,
hverkuil@xs4all.nl, m.szyprowski@samsung.com,
riverful.kim@samsung.com, sw0312.kim@samsung.com,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH/RFC v4 01/12] V4L: Add helper function for standard integer menu controls
Date: Sun, 06 May 2012 13:12:59 +0300 [thread overview]
Message-ID: <4FA64EAB.20600@iki.fi> (raw)
In-Reply-To: <1336156337-10935-2-git-send-email-s.nawrocki@samsung.com>
Hi Sylwester,
Sylwester Nawrocki wrote:
> This patch adds v4l2_ctrl_new_std_int_menu() helper function which can
> be used in drivers for creating standard integer menu control. It is
> similar to v4l2_ctrl_new_std_menu(), except it doesn't have a mask
> parameter and an additional qmenu parameter allows passing an array
> of signed 64-bit integers constituting the menu items.
It would make sense to have the mask and no pointer to the menu items if
the menu items are universally the same. This could come into question
on some standards, for example. For example, we currently have bit rates
in controls but they are strings, not integers. I could imagine we will
have such menus in the future.
I'd suggest to rename v4l2_ctrl_new_std_int_menu() as
v4l2_ctrl_new_int_menu(), as opposed to the former which would use
standardised items in the menu --- to be implemented when needed.
Kind regards,
--
Sakari Ailus
sakari.ailus@iki.fi
next prev parent reply other threads:[~2012-05-06 12:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 18:32 [PATCH/RFC v4 00/13] V4L: camera control enhancements Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 01/12] V4L: Add helper function for standard integer menu controls Sylwester Nawrocki
2012-05-06 10:12 ` Sakari Ailus [this message]
2012-05-06 17:00 ` Sylwester Nawrocki
2012-05-06 18:51 ` [PATCH v5 " Sylwester Nawrocki
2012-05-07 15:05 ` Sakari Ailus
2012-05-04 18:32 ` [PATCH/RFC v4 02/12] V4L: Add camera exposure bias control Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 03/12] V4L: Add an extended camera white balance control Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 04/12] V4L: Add camera wide dynamic range control Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 05/12] V4L: Add camera image stabilization control Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 06/12] V4L: Add camera ISO sensitivity controls Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 07/12] V4L: Add camera exposure metering control Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 08/12] V4L: Add camera scene mode control Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 09/12] V4L: Add camera 3A lock control Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 10/12] V4L: Add auto focus targets to the selections API Sylwester Nawrocki
2012-05-06 18:22 ` Sakari Ailus
2012-05-08 10:46 ` Sylwester Nawrocki
2012-05-13 0:06 ` Sakari Ailus
2012-05-04 18:32 ` [PATCH/RFC v4 11/12] V4L: Add auto focus targets to the subdev " Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 12/12] V4L: Add camera auto focus controls Sylwester Nawrocki
2012-05-06 18:46 ` Sakari Ailus
2012-05-09 10:11 ` Sylwester Nawrocki
2012-05-09 17:39 ` Sylwester Nawrocki
2012-05-06 18:58 ` [PATCH v5 " Sylwester Nawrocki
2012-05-04 18:32 ` [PATCH/RFC v4 13/13] V4L: Add S5C73M3 sensor sub-device driver Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA64EAB.20600@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=g.liakhovetski@gmx.de \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=moinejf@free.fr \
--cc=riverful.kim@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.