From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: drivers: Probable misuses of ||
Date: Mon, 07 May 2012 07:45:44 -0300 [thread overview]
Message-ID: <4FA7A7D8.7000806@redhat.com> (raw)
In-Reply-To: <1333580415.23520.29.camel@joe2Laptop>
Malcolm,
Em 04-04-2012 20:00, Joe Perches escreveu:
> Likely these should be && not ||
>
> drivers/scsi/FlashPoint.c: if(bit_cnt != 0 || bit_cnt != 8)
> drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT)
> drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT)
Could you please take a look on the above?
Thanks!
Mauro
> drivers/media/rc/fintek-cir.c: if ((chip != 0x0408) || (chip != 0x0804))
>
>
next prev parent reply other threads:[~2012-05-07 10:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 23:00 drivers: Probable misuses of || Joe Perches
2012-05-04 21:54 ` Joe Perches
2012-05-04 22:02 ` Mark Brown
2012-05-04 22:09 ` Joe Perches
2012-05-04 22:13 ` Mark Brown
2012-05-05 16:00 ` Guenter Roeck
2012-05-07 8:36 ` Mark Brown
2012-05-07 16:20 ` Joe Perches
2012-05-07 16:34 ` Mark Brown
2012-05-04 22:56 ` Alan Cox
2012-05-04 23:13 ` Joe Perches
2012-05-04 22:45 ` richard -rw- weinberger
2012-05-07 10:45 ` Mauro Carvalho Chehab [this message]
2012-05-07 15:22 ` [PATCH] re: drivers: Probable misuses of || - it913x.c Malcolm Priestley
2012-05-07 11:04 ` drivers: Probable misuses of || Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA7A7D8.7000806@redhat.com \
--to=mchehab@redhat.com \
--cc=JBottomley@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.