Re: WARNING: at net/mac80211/iface.c:162

[Larry Finger <Larry.Finger@lwfinger.net>]

On 05/07/2012 06:29 AM, Johannes Berg wrote:
> On Mon, 2012-05-07 at 09:55 +0200, Arend van Spriel wrote:
>> On 05/07/2012 08:34 AM, Johannes Berg wrote:
>>> On Sun, 2012-05-06 at 18:30 -0500, Larry Finger wrote:
>>>> Hi,
>>>>
>>>> I am getting the following warning from the latest wireless-testing system:
>>>>
>>>>    ------------[ cut here ]------------
>>>>    WARNING: at net/mac80211/iface.c:162 ieee80211_check_queues+0x119/0x130
>>>> [mac80211]()
>>>
>>>
>>>>        if (WARN_ON_ONCE(sdata->vif.hw_queue[i]>= n_queues))
>>>>
>>>> The warning is triggered for i, n_queues, and sdata->vif.hw_queue[i] all equal to 1.
>>>
>>> Is this a driver with just a single queue by any chance? I never tested
>>> that and probably forgot to set those up correctly.
>>>
>>
>> The bug report Larry mentions is with iwlwifi driver:
>>
>> pci, iwlwifi, NETWORK, Centrino Wireless-N 130 BGN
>
> No, the bug report says rtl8187, the user said this happened when
> plugging in the USB device.
>
> I think this will fix it:
>
> --- a/net/mac80211/iface.c
> +++ b/net/mac80211/iface.c
> @@ -206,8 +206,10 @@ static void ieee80211_set_default_queues(struct ieee80211_sub_if_data *sdata)
>   	for (i = 0; i<  IEEE80211_NUM_ACS; i++) {
>   		if (local->hw.flags&  IEEE80211_HW_QUEUE_CONTROL)
>   			sdata->vif.hw_queue[i] = IEEE80211_INVAL_HW_QUEUE;
> -		else
> +		else if (local->hw.queues>= IEEE80211_NUM_ACS)
>   			sdata->vif.hw_queue[i] = i;
> +		else
> +			sdata->vif.hw_queue[i] = 0;
>   	}
>   	sdata->vif.cab_queue = IEEE80211_INVAL_HW_QUEUE;
>   }

Yes, this patch fixes the problem.

Reported-and-Tested-by: Larry Finger <Larry.Finger@lwfinger.net>

Once you post the patch, I will update that entry at bugzilla.redhat.com.

Thanks,

Larry