From: Fabien Chouteau <chouteau@adacore.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppcmas_tlb_check: Fix effective address comparison
Date: Mon, 07 May 2012 18:45:36 +0200 [thread overview]
Message-ID: <4FA7FC30.9010604@adacore.com> (raw)
In-Reply-To: <0FFF7458-DF56-4BD1-9D12-2DD5E57B9971@suse.de>
On 05/07/2012 06:43 PM, Alexander Graf wrote:
>
> On 07.05.2012, at 18:41, Fabien Chouteau wrote:
>
>> Use size mask in both operands of effective address comparison.
>> This is the expected as the size of EPN field in MAS2 depends on page
>> size.
>>
>> Definition of EPN field from e500v2 RM:
>> EPN Effective page number: Depending on page size, only the bits
>> associated with a page boundary are valid. Bits that represent offsets
>> within a page are ignored and should be cleared.
>>
>> There is a similar (but more complicated) definition in PowerISA V2.06.
>
> Would it make sense to do this at tlbwe time? That path is a bit less hot that the tlb check :).
Why not, I'll check that tomorrow.
Thanks,
--
Fabien Chouteau
prev parent reply other threads:[~2012-05-07 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 16:41 [Qemu-devel] [PATCH] ppcmas_tlb_check: Fix effective address comparison Fabien Chouteau
2012-05-07 16:43 ` Alexander Graf
2012-05-07 16:45 ` Fabien Chouteau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA7FC30.9010604@adacore.com \
--to=chouteau@adacore.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.