From: "Arend van Spriel" <arend@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: lucas.demarchi@profusion.mobi, andrei.emeltchenko.news@gmail.com,
dh.herrmann@googlemail.com, gustavo@padovan.org,
linville@tuxdriver.com, linux-bluetooth@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix coding style
Date: Mon, 7 May 2012 22:14:01 +0200 [thread overview]
Message-ID: <4FA82D09.3010001@broadcom.com> (raw)
In-Reply-To: <20120507.160609.1784484093679983272.davem@davemloft.net>
On 05/07/2012 10:06 PM, David Miller wrote:
> From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
> Date: Mon, 7 May 2012 16:49:16 -0300
>
>> Doing so also means we don't create our own rules and impose them on
>> others, like happened some time ago
>> (https://lkml.org/lkml/2012/4/16/473).
>
> You conveniently forgot to show that Linus said that it's OK for a
> subsystem maintainer to request that kind of coding style, it's just
> not OK to impose it tree-wide.
Actually, checkpatch.pl does validate the rule being discussed here.
That could be regarded as imposing it. The SubmittingPatches document
states the following:
"At a minimum you should check your patches with the patch style
checker prior to submission (scripts/checkpatch.pl). You should
be able to justify all violations that remain in your patch."
Gr. AvS
next prev parent reply other threads:[~2012-05-07 20:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 18:59 [PATCH] Bluetooth: Fix coding style Gustavo Padovan
2012-05-06 16:02 ` Marcel Holtmann
2012-05-06 16:36 ` David Miller
2012-05-06 17:46 ` David Herrmann
2012-05-06 18:53 ` David Miller
2012-05-07 8:14 ` Andrei Emeltchenko
2012-05-07 8:21 ` Arend van Spriel
2012-05-07 8:29 ` Andrei Emeltchenko
2012-05-07 10:06 ` Arend van Spriel
2012-05-07 15:52 ` David Miller
2012-05-07 19:49 ` Lucas De Marchi
2012-05-07 20:06 ` David Miller
2012-05-07 20:14 ` Arend van Spriel [this message]
2012-05-07 21:33 ` Marcel Holtmann
2012-05-07 21:41 ` David Miller
2012-05-07 17:06 ` Marcel Holtmann
2012-05-07 17:55 ` David Miller
2012-05-07 21:22 ` Marcel Holtmann
2012-05-07 23:24 ` Joe Perches
2012-05-07 19:40 ` Lucas De Marchi
2012-05-07 15:24 ` Gustavo Padovan
2012-05-07 15:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA82D09.3010001@broadcom.com \
--to=arend@broadcom.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=davem@davemloft.net \
--cc=dh.herrmann@googlemail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.