From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE Date: Tue, 08 May 2012 09:43:34 +0200 Message-ID: <4FA8CEA6.3000008@samsung.com> References: <1336148260-19952-1-git-send-email-s.nawrocki@samsung.com> <017b01cd2cdd$4e4ff570$eaefe050$%kim@samsung.com> <4FA8CCC9.9030601@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:17594 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367Ab2EHHng (ORCPT ); Tue, 8 May 2012 03:43:36 -0400 Received: from euspt1 ([210.118.77.14]) by mailout4.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0M3P00CKP1GZ3T20@mailout4.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 08 May 2012 08:43:47 +0100 (BST) Received: from linux.samsung.com ([106.116.38.10]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M3P00H0C1GMUA@spt1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 08 May 2012 08:43:34 +0100 (BST) In-reply-to: <4FA8CCC9.9030601@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, 'Kyungmin Park' On 05/08/2012 09:35 AM, Sylwester Nawrocki wrote: > On 05/08/2012 07:42 AM, Kukjin Kim wrote: >> Sylwester Nawrocki wrote: >>> >>> Add the gate clocks and register region address definition for >>> FIMC-LITE devices available in Exynos4x12 and Exynos5 SoCs. >>> >> This is right description? I can't find your changes for EXYNOS4412 and >> EXYNOS5 here. Only this is for EXYNOS4212 SoC. > > Sorry, I wasn't precise enough. EXYNOS4_PA_FIMC_LITE is for EXYNOS4212 > and EXYNOS4412 though. Please note it is initially needed for DT platforms, > until we get proper clock DT bindings for EXYNOS. Is there, BTW, anyone > known to work on converting EXYNOS to the common clock framework ? > > This patch was intended for EXYNOS4212/4412. AFAICS clock code in > mach-exynos/clock-exynos4412.c is a subset of the EXYNOS4412 platform: ^^^^^^^^^^^^^^^^^^ Uh, should be clock-exynos4212.c. > static void __init exynos4_init_clocks(int xtal) > { > ... > if (soc_is_exynos4210()) > exynos4210_register_clocks(); > else if (soc_is_exynos4212() || soc_is_exynos4412()) > exynos4212_register_clocks(); > > exynos4_register_clocks(); > ... > } > > Should I resend the patch or could you remove " and Exynos5 SoCs" > from the description ? > > -- > > Regards, > Sylwester Nawrocki From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Tue, 08 May 2012 09:43:34 +0200 Subject: [PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE In-Reply-To: <4FA8CCC9.9030601@samsung.com> References: <1336148260-19952-1-git-send-email-s.nawrocki@samsung.com> <017b01cd2cdd$4e4ff570$eaefe050$%kim@samsung.com> <4FA8CCC9.9030601@samsung.com> Message-ID: <4FA8CEA6.3000008@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/08/2012 09:35 AM, Sylwester Nawrocki wrote: > On 05/08/2012 07:42 AM, Kukjin Kim wrote: >> Sylwester Nawrocki wrote: >>> >>> Add the gate clocks and register region address definition for >>> FIMC-LITE devices available in Exynos4x12 and Exynos5 SoCs. >>> >> This is right description? I can't find your changes for EXYNOS4412 and >> EXYNOS5 here. Only this is for EXYNOS4212 SoC. > > Sorry, I wasn't precise enough. EXYNOS4_PA_FIMC_LITE is for EXYNOS4212 > and EXYNOS4412 though. Please note it is initially needed for DT platforms, > until we get proper clock DT bindings for EXYNOS. Is there, BTW, anyone > known to work on converting EXYNOS to the common clock framework ? > > This patch was intended for EXYNOS4212/4412. AFAICS clock code in > mach-exynos/clock-exynos4412.c is a subset of the EXYNOS4412 platform: ^^^^^^^^^^^^^^^^^^ Uh, should be clock-exynos4212.c. > static void __init exynos4_init_clocks(int xtal) > { > ... > if (soc_is_exynos4210()) > exynos4210_register_clocks(); > else if (soc_is_exynos4212() || soc_is_exynos4412()) > exynos4212_register_clocks(); > > exynos4_register_clocks(); > ... > } > > Should I resend the patch or could you remove " and Exynos5 SoCs" > from the description ? > > -- > > Regards, > Sylwester Nawrocki