All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Crispin <blogic@openwrt.org>
To: dedekind1@gmail.com
Cc: MIPS Mailing List <linux-mips@linux-mips.org>,
	MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: xway_nand does not build
Date: Tue, 08 May 2012 13:01:56 +0200	[thread overview]
Message-ID: <4FA8FD24.6060908@openwrt.org> (raw)
In-Reply-To: <1336474838.23308.28.camel@sauron.fi.intel.com>

On 08/05/12 13:00, Artem Bityutskiy wrote:
> Hi John,
>
> I get the following build error when building xway_nand.c:
>
> dedekind@blue:~/git/l2-mtd$ make ARCH=mips CROSS_COMPILE=mips-linux-
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
>   UPD     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   CC      kernel/sys.o
>   LD      kernel/built-in.o
>   LD      drivers/mtd/nand/nand.o
>   CC      drivers/mtd/nand/xway_nand.o
> drivers/mtd/nand/xway_nand.c: In function 'xway_select_chip':
> drivers/mtd/nand/xway_nand.c:78:3: error: implicit declaration of function 'ltq_ebu_w32_mask' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/mtd/nand/xway_nand.o] Error 1
> make[2]: *** [drivers/mtd/nand] Error 2
> make[1]: *** [drivers/mtd] Error 2
> make: *** [drivers] Error 2
>
> and I cannot figure out how to fix this. This build failure makes
> me really unhappy and shame on me I did not notice it before, of
> course. Would you have a fix?

Hi,

I should have spotted this myself infact. I split these patches out of a
huge series and did infact check that it builds outside the series.
looks like i missed a define. Would it be possible, that patch 4 of my
series flows via Ralfs MIPS tree ? That way we dont need to split out a
single "#define ltq_ebu_w32_mask" out of the bigger MIPS series ?

Sorry about this,
John



> I am attaching the defconfig which I used.
>

  reply	other threads:[~2012-05-08 11:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 11:00 xway_nand does not build Artem Bityutskiy
2012-05-08 11:01 ` John Crispin [this message]
2012-05-08 11:13   ` Artem Bityutskiy
2012-05-08 11:11     ` John Crispin
2012-05-08 11:21       ` Artem Bityutskiy
2012-05-08 11:22       ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA8FD24.6060908@openwrt.org \
    --to=blogic@openwrt.org \
    --cc=dedekind1@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.