From: Minho Ban <mhban@samsung.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] PM / Hibernate : Add wait for disk detection if resume_file is MAJOR:MINOR style
Date: Wed, 09 May 2012 17:03:42 +0900 [thread overview]
Message-ID: <4FAA24DE.6000709@samsung.com> (raw)
In-Reply-To: <201205082328.54057.rjw@sisk.pl>
On 05/09/2012 06:28 AM, Rafael J. Wysocki wrote:
> On Tuesday, May 08, 2012, Minho Ban wrote:
>> On 05/08/2012 04:39 AM, Rafael J. Wysocki wrote:
>>>> + int partno;
>>>> + while (!get_gendisk(swsusp_resume_device, &partno))
>>>> + msleep(10);
>>>> + }
>>>> +
>>>> Check_image:
>>>> pr_debug("PM: Hibernation image partition %d:%d present\n",
>>>> MAJOR(swsusp_resume_device), MINOR(swsusp_resume_device));
>>>
>>> Besides, I'd like the documentation to be updated to reflect this change too.
>>
>> Do you mean resumewait is needed to be updated in kernel-parameters.txt?
>
> No, but it should be decumented what exactly is to be passed in
> the resume= command line option (in kernel-parameters.txt). Please do that
> when you're at it.
>
> Thanks,
> Rafael
>
OK, I'll add some comment on the resume= to clarify what partition format could be
used.
Regards,
Minho Ban
next prev parent reply other threads:[~2012-05-09 8:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 8:26 [RFC/PATCH] PM / Hibernate : Add wait for disk detection if resume_file is MAJOR:MINOR style Minho Ban
2012-05-07 19:39 ` Rafael J. Wysocki
2012-05-07 23:56 ` Minho Ban
2012-05-08 21:28 ` Rafael J. Wysocki
2012-05-09 8:03 ` Minho Ban [this message]
2012-05-09 6:12 ` Srivatsa S. Bhat
2012-05-09 8:03 ` Minho Ban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAA24DE.6000709@samsung.com \
--to=mhban@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.