From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 0 of 4] Add commands to automatically prep devices for pass-through Date: Wed, 9 May 2012 12:11:56 +0100 Message-ID: <4FAA50FC.60105@eu.citrix.com> References: <4FAA4D4F.9070804@cantab.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FAA4D4F.9070804@cantab.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 09/05/12 11:56, David Vrabel wrote: > pci_assignable_add: Make a device assignable to guests. This involves > unbinding the device from its old driver, creating a slot for it in > pciback (if necessary), and binding it to pciback. > > pci_assignable_list: List devices assignable to guests. Just renamed > from pci_list_assignable. > You use underscores here (and elsewhere in the commit message) but the > code uses dashes. Suggest updating the commit messages with the format > for the commands. I used underscores in the patch to libxl, because the libxl functions have undescores, and dashes in the xl patch, because the xl commands use dashes. :-) -George