All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	alsa-devel@alsa-project.org, "Cousson, Benoit" <b-cousson@ti.com>,
	Liam Girdwood <lrg@ti.com>,
	Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH] ASoC: twl6040: Support for DT
Date: Wed, 09 May 2012 15:01:23 +0300	[thread overview]
Message-ID: <4FAA5C93.6020703@ti.com> (raw)
In-Reply-To: <20120508134123.GQ15893@opensource.wolfsonmicro.com>

Hi Mark,

On 05/08/2012 04:41 PM, Mark Brown wrote:
> On Tue, May 08, 2012 at 03:42:41PM +0300, Peter Ujfalusi wrote:
>> On 05/08/2012 03:26 PM, Mark Brown wrote:
> 
>>> Why are we loading MFD components using device tree?  It seems like
>>> we're doing something very wrong if we need people to explicitly write
> 
>> I have based the twl6040 DT structure on the already existing twl4030,
>> twl6030 MFD parts.
> 
> This really isn't relevant to the issue...

I thought it was...

>> Also without a DT entry I will not have a way to use phandle to connect
>> the codec in the machine driver.
> 
> Of course you do!  There's going to be a device tree entry for the chip,
> things can point at this perfectly happily.

That's true but what can I do with that in the ASoC machine driver? The
chip driver is _not_ the codec driver.
I can craft the pdata for the MFD child devices out from the DT
information but then the child devices will have no dev.of_node since
they were not probed via OF.
So I would have not phandle for the codec to be used to define the
dai-link connection within the sound dts section.

Am I missing something here?

-- 
Péter

  reply	other threads:[~2012-05-09 12:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 11:52 [PATCH] ASoC: twl6040: Support for DT Peter Ujfalusi
2012-05-08 12:26 ` Mark Brown
2012-05-08 12:42   ` Peter Ujfalusi
2012-05-08 13:41     ` Mark Brown
2012-05-09 12:01       ` Peter Ujfalusi [this message]
2012-05-09 13:35         ` Mark Brown
2012-05-10 12:55           ` Peter Ujfalusi
2012-05-11 14:05             ` Mark Brown
     [not found]           ` <20120509133511.GQ3955-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-11 11:02             ` Cousson, Benoit
2012-05-11 13:08               ` Mark Brown
     [not found]                 ` <20120511130816.GB3960-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-11 15:44                   ` Cousson, Benoit
2012-05-11 20:34                     ` Mark Brown
2012-05-14 11:38                       ` Peter Ujfalusi
2012-05-14 12:11                         ` Mark Brown
2012-05-15  8:00                           ` Peter Ujfalusi
2012-05-14 15:34                   ` Tony Lindgren
2012-05-15  7:41                     ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAA5C93.6020703@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b-cousson@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=misael.lopez@ti.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.