From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS6Jl-0001TK-18 for qemu-devel@nongnu.org; Wed, 09 May 2012 08:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SS6Je-0005uo-W5 for qemu-devel@nongnu.org; Wed, 09 May 2012 08:48:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS6Je-0005rB-MW for qemu-devel@nongnu.org; Wed, 09 May 2012 08:48:26 -0400 Message-ID: <4FAA6794.9070509@redhat.com> Date: Wed, 09 May 2012 14:48:20 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1336488722-13120-1-git-send-email-pbonzini@redhat.com> <1336488722-13120-12-git-send-email-pbonzini@redhat.com> <4FAA671C.6020500@redhat.com> In-Reply-To: <4FAA671C.6020500@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1 11/22] qemu-io: correctly print non-integer values as decimals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 09/05/2012 14:46, Kevin Wolf ha scritto: >> > The changes to all other files were scripted with sed, so there were >> > no "surprises" beyond 027.out and 033.out. >> > >> > Signed-off-by: Paolo Bonzini >> > --- >> > 035.out has an extra long line which stumps git send-email, >> > so I forced generation of a binary diff. Always learning >> > new things. > How do you do that, and even for single files in a larger commit? I added this temporarily to my ".git/info/attributes": tests/qemu-iotests/035.out -diff > When I patched 035.out in the past, I used git send-email --no-validate, > but binary patches are probably better. Depends on what the change is. It does add a step for the reviewer to look at the diff. Paolo