Re: [Qemu-devel] [PATCH 2/3] megasas: LSI Megaraid SAS HBA emulation

[Hannes Reinecke <hare@suse.de>]

On 05/09/2012 03:02 PM, Alexander Graf wrote:
> On 05/09/2012 11:52 AM, Hannes Reinecke wrote:
>> This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA.
>> I've tested it to work with Linux, Windows Vista, and Windows7.
> 
> agraf@wolfberry-1:/home/agraf/git/qemu.megasas> git pw am 157890
> ERROR: return is not a function, parentheses are not required
> #303: FILE: hw/megasas.c:246:
> +    return (iov_count - i);
> 
> WARNING: braces {} are necessary for all arms of this statement
> #653: FILE: hw/megasas.c:596:
> +    if (cmd->frame->header.sge_count)
> [...]
> 
> WARNING: braces {} are necessary for all arms of this statement
> #1047: FILE: hw/megasas.c:990:
> +        if (num_ld_disks >= max_ld_disks)
> [...]
> 
> WARNING: braces {} are necessary for all arms of this statement
> #1513: FILE: hw/megasas.c:1456:
> +    if (cmd->frame->header.frame_cmd == MFI_CMD_DCMD)
> [...]
> +    else
> [...]
> 
> total: 1 errors, 3 warnings, 1978 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> checkpatch failed, still apply? [y|N]
> 
Updated patch series (v17) send.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)