From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1SS7ff-0003Nl-6g
	for qemu-devel@nongnu.org; Wed, 09 May 2012 10:15:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1SS7fV-0002ze-8U
	for qemu-devel@nongnu.org; Wed, 09 May 2012 10:15:14 -0400
Received: from cantor2.suse.de ([195.135.220.15]:46597 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hare@suse.de>)
	id 1SS7fV-0002xR-2n
	for qemu-devel@nongnu.org; Wed, 09 May 2012 10:15:05 -0400
Message-ID: <4FAA7BE7.7080907@suse.de>
Date: Wed, 09 May 2012 16:15:03 +0200
From: Hannes Reinecke <hare@suse.de>
MIME-Version: 1.0
References: <1336557163-23645-1-git-send-email-hare@suse.de>
	<1336557163-23645-3-git-send-email-hare@suse.de>
	<4FAA6AED.7030609@suse.de>
In-Reply-To: <4FAA6AED.7030609@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/3] megasas: LSI Megaraid SAS HBA emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>

On 05/09/2012 03:02 PM, Alexander Graf wrote:
> On 05/09/2012 11:52 AM, Hannes Reinecke wrote:
>> This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA.
>> I've tested it to work with Linux, Windows Vista, and Windows7.
>=20
> agraf@wolfberry-1:/home/agraf/git/qemu.megasas> git pw am 157890
> ERROR: return is not a function, parentheses are not required
> #303: FILE: hw/megasas.c:246:
> +    return (iov_count - i);
>=20
> WARNING: braces {} are necessary for all arms of this statement
> #653: FILE: hw/megasas.c:596:
> +    if (cmd->frame->header.sge_count)
> [...]
>=20
> WARNING: braces {} are necessary for all arms of this statement
> #1047: FILE: hw/megasas.c:990:
> +        if (num_ld_disks >=3D max_ld_disks)
> [...]
>=20
> WARNING: braces {} are necessary for all arms of this statement
> #1513: FILE: hw/megasas.c:1456:
> +    if (cmd->frame->header.frame_cmd =3D=3D MFI_CMD_DCMD)
> [...]
> +    else
> [...]
>=20
> total: 1 errors, 3 warnings, 1978 lines checked
>=20
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> checkpatch failed, still apply? [y|N]
>=20
Updated patch series (v17) send.

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)