All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] coroutine-ucontext broken for x86-32
Date: Wed, 09 May 2012 17:37:40 +0300	[thread overview]
Message-ID: <4FAA8134.9060701@redhat.com> (raw)
In-Reply-To: <CAFEAcA-RK+_RAYZP9qYvhyuzF_o2OF=q7kYsqPOwtKLknPqPeQ@mail.gmail.com>

On 05/09/2012 02:15 PM, Peter Maydell wrote:
> I think it's becoming increasingly obvious that the setcontext/getcontext
> code path is not very well used and prone to nasty libc bugs. Trying
> to implement coroutines in C is just a really bad idea and I think
> we should be trying to reduce our use of them if we possibly can,
> presumably by switching to actually using threads where we really
> need the parallelism.
>

I happen to like coroutines, but if we switch to threads, we should
ensure that we eliminate the extra context switch if the layer below
(usually posix-aio-compat) also uses threads.  That leaves a theoretical
regression with qcow2-on-native-aio, but that's a fairly rare use case.

-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2012-05-09 14:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 19:35 [Qemu-devel] coroutine-ucontext broken for x86-32 Jan Kiszka
2012-05-09  7:32 ` Michael Tokarev
2012-05-09 11:12   ` Jan Kiszka
2012-05-09 10:11 ` Kevin Wolf
2012-05-09 10:55   ` Jan Kiszka
2012-05-09 11:15   ` Peter Maydell
2012-05-09 11:38     ` Jan Kiszka
2012-05-09 17:17       ` Anthony Liguori
2012-05-09 17:25         ` Jan Kiszka
2012-05-09 17:31           ` Anthony Liguori
2012-05-09 18:21             ` Jan Kiszka
2012-05-09 14:37     ` Avi Kivity [this message]
2012-05-09 18:05 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAA8134.9060701@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kwolf@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.