Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2012-05-03 20:51, malc wrote:
> On Thu, 3 May 2012, Jan Kiszka wrote:
> 
>> On 2012-05-03 16:32, malc wrote:
>>> On Thu, 3 May 2012, Jan Kiszka wrote:
>>>
>>>> Not only clean up enabled voices but any registered one. Backends like
>>>> pulsaudio rely on unconditional fini handler invocations.
>>>>
>>>> This fixes "Memory pool destroyed but not all memory blocks freed!"
>>>> warnings on VM shutdowns when pa is used.
>>>
>>> Perhaps it's better to actually handle VOICE_DISABLE in pa's ctl_[in|out]?
>>
>> This might be some additional issue (that pa is not supporting
>> enable/disable). In any case, it is unrelated to this one: fini
>> corresponds to init. And as we initialized the voice, we also have to
>> finalize it on shutdown. That's what this patch is fixing.
>>
> 
> The issue is that i don't remember exactly why it iterates only over
> enabled voices, maybe there was a reason, maybe there wasn't, need to
> think it over. 

Any news on this?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux