From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSDNE-0004aB-Oe for qemu-devel@nongnu.org; Wed, 09 May 2012 16:20:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSDNC-0007ot-Ts for qemu-devel@nongnu.org; Wed, 09 May 2012 16:20:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50715 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSDNC-0007oF-MQ for qemu-devel@nongnu.org; Wed, 09 May 2012 16:20:34 -0400 Message-ID: <4FAAD18F.4070604@suse.de> Date: Wed, 09 May 2012 22:20:31 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329189019-13710-1-git-send-email-bo.novell@gmail.com> In-Reply-To: <1329189019-13710-1-git-send-email-bo.novell@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Bo Yang , Mark McLoughlin , Alexander Graf , Anthony Liguori , Bruce Rogers Am 14.02.2012 04:10, schrieb bo.novell@gmail.com: > From: Bo Yang >=20 > Windows 2008 sp2 tries to read mac address from phys > and then write the read value into it. This patch > is a workaround for the issue. >=20 > Signed-off-by: Bo Yang > --- > hw/rtl8139.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Ping! Who feels responsible for reviewing this? It would be a candidate for 1.1 and 0.15.x (BNC#722643). Only issue I see is that the subject could be improved (saying what it does rather than what was broken before, e.g. "rtl8139: Init phys with MAC address"). Regards, Andreas > diff --git a/hw/rtl8139.c b/hw/rtl8139.c > index 1668390..074a14a 100644 > --- a/hw/rtl8139.c > +++ b/hw/rtl8139.c > @@ -3476,6 +3476,8 @@ static int pci_rtl8139_init(PCIDevice *dev) > s->eeprom.contents[7] =3D s->conf.macaddr.a[0] | s->conf.macaddr.a= [1] << 8; > s->eeprom.contents[8] =3D s->conf.macaddr.a[2] | s->conf.macaddr.a= [3] << 8; > s->eeprom.contents[9] =3D s->conf.macaddr.a[4] | s->conf.macaddr.a= [5] << 8; > + /* workaround broken windows 2008 sp2 driver. */ > + memcpy(s->phys, s->conf.macaddr.a, 6); > =20 > s->nic =3D qemu_new_nic(&net_rtl8139_info, &s->conf, > object_get_typename(OBJECT(dev)), dev->qdev.= id, s); --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg