From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSEaW-0007ht-ER for qemu-devel@nongnu.org; Wed, 09 May 2012 17:38:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSEaU-0006g7-JJ for qemu-devel@nongnu.org; Wed, 09 May 2012 17:38:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55955 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSEaU-0006er-9s for qemu-devel@nongnu.org; Wed, 09 May 2012 17:38:22 -0400 Message-ID: <4FAAE3CB.6080004@suse.de> Date: Wed, 09 May 2012 23:38:19 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329189019-13710-1-git-send-email-bo.novell@gmail.com> <4FAAD18F.4070604@suse.de> <4FAADC13.4050906@suse.de> <5AE33261-DEB3-4F7B-96B3-C51D925B2C8A@suse.de> <4FAA8CDB02000048000C3B22@novprvoes0310.provo.novell.com> In-Reply-To: <4FAA8CDB02000048000C3B22@novprvoes0310.provo.novell.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bruce Rogers , Bo Yang Cc: Mark McLoughlin , Alexander Graf , Anthony Liguori , qemu-devel@nongnu.org Am 09.05.2012 23:27, schrieb Bruce Rogers: > >>> On 5/9/2012 at 03:06 PM, Alexander Graf wrote:=20 >=20 >> On 09.05.2012, at 23:05, Andreas F=E4rber wrote: >> >>> Am 09.05.2012 23:00, schrieb Alexander Graf: >>>> >>>> On 09.05.2012, at 22:20, Andreas F=E4rber wrote: >>>> >>>>> Am 14.02.2012 04:10, schrieb bo.novell@gmail.com: >>>>>> From: Bo Yang >>>>>> >>>>>> Windows 2008 sp2 tries to read mac address from phys >>>>>> and then write the read value into it. This patch >>>>>> is a workaround for the issue. >>>>>> >>>>>> Signed-off-by: Bo Yang >>>>>> --- >>>>>> hw/rtl8139.c | 2 ++ >>>>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>>> >>>>> Ping! Who feels responsible for reviewing this? >>>>> It would be a candidate for 1.1 and 0.15.x (BNC#722643). >>>> >>>> I thought the real bug was that the reset function didn't get called= ? >>> >>> That was for the e1000 that I was working on (BNC#722958). I believe = Bo >>> tested the combination of both patches? >> >> IIRC the bug was the same, just that you found the root cause and Bo c= ame up=20 >> with this patch :). >=20 > That is my recollection as well. Even better then, less work. Bo, in such a case, the patch should've been recalled (by a reply). Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg