From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] [PATCH 1.1] Switch SIG_IPI to SIGUSR1
Date: Wed, 09 May 2012 19:14:25 -0300 [thread overview]
Message-ID: <4FAAEC41.70608@siemens.com> (raw)
Use SIGUSR1 unconditionally as SIG_IPI. First, ucontext coroutines tend
to corrupt RT signal masks due to a 32-on-64-bit Linux kernel bug. And,
second, there appears to be no advantage in using RT signals for VCPU
kicking.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
As people prefer to stick with ucontext, this replaces the backend
switch for i386-linux.
Avi, you once committed the RT signal based SIG_IPI version to
qemu-kvm. Can you confirm that SIGUSR1 comes with no downside?
This is also stable material.
main-loop.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/main-loop.h b/main-loop.h
index c06b8bc..dce1cd9 100644
--- a/main-loop.h
+++ b/main-loop.h
@@ -25,11 +25,7 @@
#ifndef QEMU_MAIN_LOOP_H
#define QEMU_MAIN_LOOP_H 1
-#ifdef SIGRTMIN
-#define SIG_IPI (SIGRTMIN+4)
-#else
#define SIG_IPI SIGUSR1
-#endif
/**
* qemu_init_main_loop: Set up the process so that it can run the main loop.
--
1.7.3.4
next reply other threads:[~2012-05-09 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:14 Jan Kiszka [this message]
2012-05-09 22:36 ` [Qemu-devel] [PATCH 1.1] Switch SIG_IPI to SIGUSR1 Andreas Färber
2012-05-10 9:35 ` Avi Kivity
2012-05-14 15:04 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAAEC41.70608@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.