All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: I have question for supporting irq_domain of MAX8997
Date: Thu, 10 May 2012 09:02:56 +0900	[thread overview]
Message-ID: <4FAB05B0.2030906@samsung.com> (raw)
In-Reply-To: <CAJuYYwRDe_KyXnPxZq_fGyHuYAB=e76AaRZwoe9UjUer=QX3YA@mail.gmail.com>

Dear Thomas,

On 05/09/2012 11:27 PM, Thomas Abraham wrote:

> The irq domain support for max8997 irq is already posted. I am yet to
> address some of the review comments for those patches and hence the
> max8997 dt (+ irqdomain) patches are still work in progress. But the
> irq domain support for max8997 is complete.

I did see your patch for irq_domain support for max8997 in below git repository.

http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=shortlog;h=refs/heads/for-next

But, I checked that your patch was reverted because it breaks the build
of the muic driver
reported by Stephen Rothwell. You can check this following url.
http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=commit;h=82b719b11fd750188c125078ad6a6c0d23219dfb

Also, Do you test irq domain of MAX8997 with max8997-muic driver or others?
While looking through the drivers/mfd/max8997-irq.c, I could not find
initialization code
of max8997->irq_domain(field of 'struct max8997_dev'). When tested your
patch with
max8997-muic driver, max8997->irq_domain variable is NULL. I think that
you set only
local variable(struct irq_domain *domain) in max8997_irq_init().

Thank you,
Chanwoo Choi

      reply	other threads:[~2012-05-10  0:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09  4:24 I have question for supporting irq_domain of MAX8997 Chanwoo Choi
2012-05-09 14:27 ` Thomas Abraham
2012-05-10  0:02   ` Chanwoo Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAB05B0.2030906@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.