From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-fbdev@vger.kernel.org, agust@denx.de
Subject: Re: [PATCH] video: mb862xx-i2c: local functions should not be exposed globally
Date: Thu, 10 May 2012 00:12:16 +0000 [thread overview]
Message-ID: <4FAB07E0.5070209@gmx.de> (raw)
In-Reply-To: <201205021734.16988.hartleys@visionengravers.com>
On 05/03/2012 12:34 AM, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent them from being exposed globally.
>
> Quiets the sparse warnings:
>
> warning: symbol 'mb862xx_i2c_stop' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: Anatolij Gustschin <agust@denx.de>
Applied.
Thanks,
Florian Tobias Schandinat
>
> ---
>
> diff --git a/drivers/video/mb862xx/mb862xx-i2c.c b/drivers/video/mb862xx/mb862xx-i2c.c
> index 273769b..c87e17a 100644
> --- a/drivers/video/mb862xx/mb862xx-i2c.c
> +++ b/drivers/video/mb862xx/mb862xx-i2c.c
> @@ -68,7 +68,7 @@ static int mb862xx_i2c_read_byte(struct i2c_adapter *adap, u8 *byte, int last)
> return 1;
> }
>
> -void mb862xx_i2c_stop(struct i2c_adapter *adap)
> +static void mb862xx_i2c_stop(struct i2c_adapter *adap)
> {
> struct mb862xxfb_par *par = adap->algo_data;
>
>
prev parent reply other threads:[~2012-05-10 0:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 0:34 [PATCH] video: mb862xx-i2c: local functions should not be exposed globally H Hartley Sweeten
2012-05-03 0:34 ` H Hartley Sweeten
2012-05-10 0:12 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAB07E0.5070209@gmx.de \
--to=florianschandinat@gmx.de \
--cc=agust@denx.de \
--cc=hartleys@visionengravers.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.