From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Diwakar Tundlam <dtundlam@nvidia.com>,
"'Ingo Molnar'" <mingo@kernel.org>,
"'David Rientjes'" <rientjes@google.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Subject: Re: [PATCH] sched: Make nr_uninterruptible count a signed value
Date: Thu, 10 May 2012 11:41:33 +0800 [thread overview]
Message-ID: <4FAB38ED.5050200@linux.vnet.ibm.com> (raw)
In-Reply-To: <1336551100.27020.84.camel@laptop>
On 05/09/2012 04:11 PM, Peter Zijlstra wrote:
> On Tue, 2012-05-08 at 15:46 -0700, Diwakar Tundlam wrote:
>> Maybe it is an artifact of 32-bit machine displaying 64-bit print format.
>> An (unsigned long)(-24) promoted to (signed long long) ends up as 4294967272.
>> As seen in my output of sched_debug.
>
> Ah, quite possible. %Ld is indeed %lld and the value is long, not long
> long. So the proper fix is to fudge that printk statement somehow.
Could we use SEQ_printf for nr_uninterruptible, just like we did on
rq->load.weight?
Regards,
Michael Wang
>
>> Your machine is probably natively 64-bit.
>
> Yeah, I gave up on 32bit computing a while ago..
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2012-05-10 3:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 21:39 [PATCH] sched: Make nr_uninterruptible count a signed value Diwakar Tundlam
2012-05-08 21:56 ` Peter Zijlstra
2012-05-08 22:14 ` Diwakar Tundlam
2012-05-08 22:27 ` Peter Zijlstra
2012-05-08 22:29 ` Peter Zijlstra
2012-05-08 22:46 ` Diwakar Tundlam
2012-05-09 7:49 ` Michael Wang
2012-05-09 18:55 ` Diwakar Tundlam
2012-05-10 4:46 ` Michael Wang
2012-05-09 8:11 ` Peter Zijlstra
2012-05-09 19:04 ` Diwakar Tundlam
2012-05-10 3:41 ` Michael Wang [this message]
2012-05-10 9:46 ` Peter Zijlstra
2012-05-11 2:19 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAB38ED.5050200@linux.vnet.ibm.com \
--to=wangyun@linux.vnet.ibm.com \
--cc=dtundlam@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.