All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kazior <michal.kazior@tieto.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 5/7] cfg80211: extend get_channel to take wdev argument
Date: Thu, 10 May 2012 11:05:46 +0200	[thread overview]
Message-ID: <4FAB84EA.4060306@tieto.com> (raw)
In-Reply-To: <1336634995.4334.7.camel@jlt3.sipsolutions.net>

Johannes Berg wrote:
>
>>   	struct ieee80211_channel *(*get_channel)(struct wiphy *wiphy,
>> -					       enum nl80211_channel_type *type);
>> +						 struct wireless_dev *wdev,
>> +						 enum nl80211_channel_type *type);
>
> Hmm. This is mostly used for monitor mode, and there we would have to
> return NULL anyway while using multiple channels at the same time. Is it
> really worth the complexity?

Would we really have to return NULL? With my last patch that moves 
oper_channel to sdata it can return proper channel.

But then monitor mode.. ugh.


-- 
Pozdrawiam / Best regards, Michal Kazior.

  reply	other threads:[~2012-05-10  9:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10  6:44 [RFC/PATCH] multi-channel preparation work Michal Kazior
2012-05-10  6:44 ` [PATCH 1/7] mac80211: add tracking of temporary offchannel sdata Michal Kazior
2012-05-10  7:26   ` Johannes Berg
2012-05-10  7:57     ` Michal Kazior
2012-05-10  8:02       ` Johannes Berg
2012-05-10  6:44 ` [PATCH 2/7] mac80211: split channel logic from hw_config Michal Kazior
2012-05-10  6:44 ` [PATCH 3/7] mac80211: refactor ieee80211_set_channel_type Michal Kazior
2012-05-10  6:44 ` [PATCH 4/7] mac80211: introduce ieee80211_oper_channel_type Michal Kazior
2012-05-10  6:44 ` [PATCH 5/7] cfg80211: extend get_channel to take wdev argument Michal Kazior
2012-05-10  7:29   ` Johannes Berg
2012-05-10  9:05     ` Michal Kazior [this message]
2012-05-10 10:57       ` Johannes Berg
2012-05-10  6:44 ` [PATCH 6/7] mac80211: remove _oper_channel_type Michal Kazior
2012-05-10  6:44 ` [PATCH 7/7] mac80211: move oper_channel to sdata Michal Kazior
2012-05-10  7:31   ` Johannes Berg
2012-05-10  8:59     ` Michal Kazior
2012-05-11 12:11 ` [RFC/PATCH] multi-channel preparation work Johannes Berg
2012-05-11 12:39   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAB84EA.4060306@tieto.com \
    --to=michal.kazior@tieto.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.