All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Brian C. Lane" <bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Fail to boot if mediacheck fails (#817419)
Date: Thu, 10 May 2012 11:24:54 +0200	[thread overview]
Message-ID: <4FAB8966.70600@redhat.com> (raw)
In-Reply-To: <1336587303-3778-1-git-send-email-bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Am 09.05.2012 20:15, schrieb Brian C. Lane:
> From: "Brian C. Lane" <bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> 
> The return value of checkisomd5 was being ignored.
> ---
>  modules.d/90dmsquash-live/dmsquash-live-root.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/modules.d/90dmsquash-live/dmsquash-live-root.sh b/modules.d/90dmsquash-live/dmsquash-live-root.sh
> index 2aaec28..fdbd6f5 100755
> --- a/modules.d/90dmsquash-live/dmsquash-live-root.sh
> +++ b/modules.d/90dmsquash-live/dmsquash-live-root.sh
> @@ -33,7 +33,7 @@ fi
>  getarg rd.live.check check || check=""
>  if [ -n "$check" ]; then
>      [ -x /bin/plymouth ] && /bin/plymouth --hide-splash
> -    checkisomd5 --verbose $livedev || :
> +    checkisomd5 --verbose $livedev
>      if [ $? -ne 0 ]; then
>          die "CD check failed!"
>          exit 1


So, it was wrong from the beginning on... rofl..


commit c56b63d1bd06e3eaf149502d7c46c59a5978fd44
Author: Jeremy Katz <katzj-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date:   Wed Jul 22 16:06:29 2009 -0400

    Support checking the iso

    Support checking the iso image with checkisomd5 if available

  parent reply	other threads:[~2012-05-10  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 18:15 [PATCH] Fail to boot if mediacheck fails (#817419) Brian C. Lane
     [not found] ` <1336587303-3778-1-git-send-email-bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-10  9:24   ` Harald Hoyer [this message]
     [not found]     ` <4FAB8966.70600-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-10 14:23       ` John Reiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAB8966.70600@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.