From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/irq: fix locking for c/s
 24707:96987c324a4f debugging code
Date: Thu, 10 May 2012 10:26:25 +0100
Message-ID: <4FAB89C1.6040702@citrix.com>
References: <4FABA4A10200007800082A9B@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4FABA4A10200007800082A9B@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 10/05/12 10:21, Jan Beulich wrote:
> Without this, dump_irqs() may try to acquire the lock the caller is
> currently holding.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

With the proviso that this is patch will disappear when all (3 so far)
of these debugging patches disappear.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -668,6 +668,7 @@ void irq_move_cleanup_interrupt(struct c
>              {
>                  if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
>                  {
> +                    spin_unlock(&desc->lock);
>                      bitmap_scnlistprintf(keyhandler_scratch,
>                                           sizeof(keyhandler_scratch),
>                                           desc->arch.used_vectors->_bits,
>
>
>

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com