From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from nm15.access.bullet.mail.mud.yahoo.com ([66.94.237.216]:23518 "HELO nm15.access.bullet.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753170Ab2EJOVi (ORCPT ); Thu, 10 May 2012 10:21:38 -0400 Message-ID: <4FABCD55.9000504@schaufler-ca.com> Date: Thu, 10 May 2012 07:14:45 -0700 From: Casey Schaufler MIME-Version: 1.0 To: Mel Gorman CC: Andrew Morton , Linux-MM , Linux-Netdev , Linux-NFS , LKML , David Miller , Trond Myklebust , Neil Brown , Christoph Hellwig , Peter Zijlstra , Mike Christie , Eric B Munson , LSM , SE Linux Subject: Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical References: <1336658065-24851-1-git-send-email-mgorman@suse.de> <1336658065-24851-3-git-send-email-mgorman@suse.de> In-Reply-To: <1336658065-24851-3-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 5/10/2012 6:54 AM, Mel Gorman wrote: > Failing to allocate a cache entry will only harm performance not > correctness. Do not consume valuable reserve pages for something > like that. Copying to the LSM and SELinux lists. > > Signed-off-by: Peter Zijlstra > Signed-off-by: Mel Gorman > --- > security/selinux/avc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > index 8ee42b2..75c2977 100644 > --- a/security/selinux/avc.c > +++ b/security/selinux/avc.c > @@ -280,7 +280,7 @@ static struct avc_node *avc_alloc_node(void) > { > struct avc_node *node; > > - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC); > + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC); > if (!node) > goto out; > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from goalie.tycho.ncsc.mil (goalie [144.51.3.250]) by tarius.tycho.ncsc.mil (8.13.1/8.13.1) with ESMTP id q4AEEbZg006646 for ; Thu, 10 May 2012 10:14:37 -0400 Message-ID: <4FABCD55.9000504@schaufler-ca.com> Date: Thu, 10 May 2012 07:14:45 -0700 From: Casey Schaufler MIME-Version: 1.0 To: Mel Gorman CC: Andrew Morton , Linux-MM , Linux-Netdev , Linux-NFS , LKML , David Miller , Trond Myklebust , Neil Brown , Christoph Hellwig , Peter Zijlstra , Mike Christie , Eric B Munson , LSM , SE Linux Subject: Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical References: <1336658065-24851-1-git-send-email-mgorman@suse.de> <1336658065-24851-3-git-send-email-mgorman@suse.de> In-Reply-To: <1336658065-24851-3-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov On 5/10/2012 6:54 AM, Mel Gorman wrote: > Failing to allocate a cache entry will only harm performance not > correctness. Do not consume valuable reserve pages for something > like that. Copying to the LSM and SELinux lists. > > Signed-off-by: Peter Zijlstra > Signed-off-by: Mel Gorman > --- > security/selinux/avc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > index 8ee42b2..75c2977 100644 > --- a/security/selinux/avc.c > +++ b/security/selinux/avc.c > @@ -280,7 +280,7 @@ static struct avc_node *avc_alloc_node(void) > { > struct avc_node *node; > > - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC); > + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC); > if (!node) > goto out; > -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx151.postini.com [74.125.245.151]) by kanga.kvack.org (Postfix) with SMTP id F1B466B011F for ; Thu, 10 May 2012 10:14:38 -0400 (EDT) Message-ID: <4FABCD55.9000504@schaufler-ca.com> Date: Thu, 10 May 2012 07:14:45 -0700 From: Casey Schaufler MIME-Version: 1.0 Subject: Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical References: <1336658065-24851-1-git-send-email-mgorman@suse.de> <1336658065-24851-3-git-send-email-mgorman@suse.de> In-Reply-To: <1336658065-24851-3-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Andrew Morton , Linux-MM , Linux-Netdev , Linux-NFS , LKML , David Miller , Trond Myklebust , Neil Brown , Christoph Hellwig , Peter Zijlstra , Mike Christie , Eric B Munson , LSM , SE Linux On 5/10/2012 6:54 AM, Mel Gorman wrote: > Failing to allocate a cache entry will only harm performance not > correctness. Do not consume valuable reserve pages for something > like that. Copying to the LSM and SELinux lists. > > Signed-off-by: Peter Zijlstra > Signed-off-by: Mel Gorman > --- > security/selinux/avc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > index 8ee42b2..75c2977 100644 > --- a/security/selinux/avc.c > +++ b/security/selinux/avc.c > @@ -280,7 +280,7 @@ static struct avc_node *avc_alloc_node(void) > { > struct avc_node *node; > > - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC); > + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC); > if (!node) > goto out; > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org