From: Clemens Ladisch <clemens@ladisch.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: ALSA calling pcm_pointer excessively?
Date: Thu, 10 May 2012 20:43:40 +0200 [thread overview]
Message-ID: <4FAC0C5C.1050405@ladisch.de> (raw)
In-Reply-To: <20120510181849.GF12727@n2100.arm.linux.org.uk>
Russell King - ARM Linux wrote:
> On Thu, May 10, 2012 at 07:13:59PM +0200, Clemens Ladisch wrote:
>> I wrote:
>>> This (untested) patch tries to avoid too many busy looping.
>>
>> Oops, off-by-one error (avail == avail_min should not wait).
>
> This is better - it now sits around 2-14% system time. I guess the
> five loops is rather arbitary?
Yes. The minimum loop limit is two (to handle wraparound at the end of
the buffer); more than that probably does not actually make sense.
Jassi Brar wrote:
> If we really want to change the behavior of play, wouldn't we want to do that
> for capture(snd_pcm_lib_read1) as well ?
Indeed. And we'd want to reuse the twake calculation.
Regards,
Clemens
next prev parent reply other threads:[~2012-05-10 18:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 16:06 ALSA calling pcm_pointer excessively? Russell King - ARM Linux
2012-05-10 16:29 ` Russell King - ARM Linux
2012-05-10 17:05 ` Clemens Ladisch
2012-05-10 17:13 ` Clemens Ladisch
2012-05-10 18:18 ` Russell King - ARM Linux
2012-05-10 18:43 ` Clemens Ladisch [this message]
2012-05-10 23:09 ` Russell King - ARM Linux
2012-05-10 17:47 ` Jassi Brar
2012-05-11 13:31 ` Takashi Iwai
2012-05-11 14:02 ` Russell King - ARM Linux
2012-05-11 14:17 ` Takashi Iwai
2012-05-11 15:04 ` Russell King - ARM Linux
2012-05-11 16:31 ` Takashi Iwai
2012-05-11 16:38 ` Russell King - ARM Linux
2012-05-11 17:07 ` Takashi Iwai
2012-05-10 16:34 ` Trent Piepho
2012-05-10 16:42 ` Russell King - ARM Linux
2012-05-10 17:00 ` Jassi Brar
2012-05-10 17:04 ` Trent Piepho
2012-05-10 17:04 ` Russell King - ARM Linux
2012-05-10 17:18 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAC0C5C.1050405@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.