All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Bird <tim.bird@am.sony.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Brian Swetland <swetland@google.com>,
	linux kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] staging: android: logger: Fix some sparse and whitespace issues
Date: Thu, 10 May 2012 14:22:59 -0700	[thread overview]
Message-ID: <4FAC31B3.7050806@am.sony.com> (raw)
In-Reply-To: <4FAC302F.2090004@am.sony.com>

Fix a few sparse warnings, and improve whitespace.

Signed-off-by: Tim Bird <tim.bird@am.sony.com>
---
 drivers/staging/android/logger.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index 9ebcf42..3e8865f 100644
--- a/drivers/staging/android/logger.c
+++ b/drivers/staging/android/logger.c
@@ -65,9 +65,9 @@ struct logger_reader {
 };

 /* logger_offset - returns index 'n' into the log via (optimized) modulus */
-size_t logger_offset(struct logger_log *log, size_t n)
+static size_t logger_offset(struct logger_log *log, size_t n)
 {
-	return n & (log->size-1);
+	return n & (log->size - 1);
 }


@@ -353,7 +353,7 @@ static ssize_t do_write_log_from_user(struct logger_log *log,
  * writev(), and aio_write(). Writes are our fast path, and we try to optimize
  * them above all else.
  */
-ssize_t logger_aio_write(struct kiocb *iocb, const struct iovec *iov,
+static ssize_t logger_aio_write(struct kiocb *iocb, const struct iovec *iov,
 			 unsigned long nr_segs, loff_t ppos)
 {
 	struct logger_log *log = file_get_log(iocb->ki_filp);
-- 
1.7.9.5



      parent reply	other threads:[~2012-05-10 21:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 21:16 [PATCH 1/2] staging: android: logger: Allocate logs dynamically at boot (v2) Tim Bird
2012-05-10 21:21 ` Greg KH
2012-05-10 21:29   ` Tim Bird
2012-05-10 21:39     ` Greg KH
2012-05-10 22:11       ` [PATCH 1/2] staging: android: logger: Allocate logs dynamically at boot (v3) Tim Bird
2012-05-10 21:22 ` Tim Bird [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAC31B3.7050806@am.sony.com \
    --to=tim.bird@am.sony.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swetland@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.