From: Josh Wu <josh.wu@atmel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bo Shen <voice.shen@atmel.com>,
javier.martin@vista-silicon.com, khali@linux-fr.org,
w.sang@pengutronix.de, jm.lin@atmel.com,
linux-input@vger.kernel.org
Subject: Re: [RFC] QT1070: change the trigger mode of QT1070
Date: Fri, 11 May 2012 16:28:22 +0800 [thread overview]
Message-ID: <4FACCDA6.7040506@atmel.com> (raw)
In-Reply-To: <20120507070424.GC22074@core.coreip.homeip.net>
Hello, Dmitry
On 5/7/2012 3:04 PM, Dmitry Torokhov wrote:
> Hi Bo,
>
> On Mon, May 07, 2012 at 10:27:33AM +0800, Bo Shen wrote:
>> The default trigger mode of QT1070 is IRQF_TRIGGER_LOW,
>> Using TRQF_TRIGGER_FALLING to replace IRQF_TRIGGER_LOW | IRQF_ONESHOT.
> Why don't you set up IRQ the way you want in board code instead of
> implementing workarounds in the driver?
The QT1070 will generate a falling edge interrupt if any valid data
coming. The workaround is only for the boarding that can handle edge
interrupt but cannot distinguish rising and falling.
So I think put this trigger set up code to board code will make thing
more complex.
>
> Thanks.
>
Best Regards,
Josh Wu
next prev parent reply other threads:[~2012-05-11 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 2:27 [RFC] QT1070: change the trigger mode of QT1070 Bo Shen
2012-05-07 7:04 ` Dmitry Torokhov
2012-05-07 7:09 ` javier Martin
2012-05-08 7:45 ` Shen, Voice
2012-05-11 8:28 ` Josh Wu [this message]
2012-05-11 9:13 ` javier Martin
2012-05-11 11:33 ` Josh Wu
2012-05-11 12:47 ` javier Martin
2012-05-14 2:57 ` Bo Shen
2012-05-14 6:59 ` javier Martin
2012-05-14 7:21 ` javier Martin
2012-05-11 16:06 ` Dmitry Torokhov
2012-05-11 16:08 ` Dmitry Torokhov
2012-05-14 2:54 ` Bo Shen
2012-05-11 8:07 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FACCDA6.7040506@atmel.com \
--to=josh.wu@atmel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=javier.martin@vista-silicon.com \
--cc=jm.lin@atmel.com \
--cc=khali@linux-fr.org \
--cc=linux-input@vger.kernel.org \
--cc=voice.shen@atmel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.