From: Laxman Dewangan <ldewangan@nvidia.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V2 2/2] dmaengine: tegra: add dma driver
Date: Fri, 11 May 2012 16:28:36 +0530 [thread overview]
Message-ID: <4FACF0DC.3050209@nvidia.com> (raw)
In-Reply-To: <1336725713.15424.1856.camel@vkoul-udesk3>
On Friday 11 May 2012 02:11 PM, Vinod Koul wrote:
> On Thu, 2012-05-10 at 10:35 +0530, Laxman Dewangan wrote:
>
>> But when we update the chan->completed_cookie for aborted cookie?
>> Otherwise I will get the DMA_IN_PROGRSS when I call dma_cookie_status()
>> but actually it is aborted.
> no in .device_tx_status, you should check if the descriptor is aborted
> or not and rteurn error for aborted descriptor.
>
OK, I will not call this function.
Also I am dropping the ONCE_NOTIFY_HALF and will add later if require. I
realize that patch patch should be simple and sufficient so that other
driver development/upstream can be unblock. Later on we can add feature
based on necessary.
I am sending the new patch with considering all your feedback.
Thanks again for review.
Thanks,
Laxman
prev parent reply other threads:[~2012-05-11 10:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 7:41 [PATCH V2 0/2] dmaengine: tegra: add dma driver Laxman Dewangan
2012-05-03 7:41 ` Laxman Dewangan
[not found] ` <1336030889-32269-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-03 7:41 ` [PATCH V2 1/2] dma: dmaengine: add slave req id in slave_config Laxman Dewangan
2012-05-03 7:41 ` Laxman Dewangan
2012-05-09 8:49 ` Vinod Koul
2012-05-09 10:27 ` Laxman Dewangan
2012-05-09 10:27 ` Laxman Dewangan
2012-05-03 7:41 ` [PATCH V2 2/2] dmaengine: tegra: add dma driver Laxman Dewangan
[not found] ` <1336030889-32269-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-09 10:14 ` Vinod Koul
2012-05-09 10:14 ` Vinod Koul
2012-05-09 11:01 ` Laxman Dewangan
2012-05-09 11:01 ` Laxman Dewangan
[not found] ` <4FAA4EA3.70001-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-10 3:34 ` Vinod Koul
2012-05-10 3:34 ` Vinod Koul
2012-05-10 5:05 ` Laxman Dewangan
2012-05-10 5:05 ` Laxman Dewangan
[not found] ` <4FAB4C7D.7030406-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-11 8:41 ` Vinod Koul
2012-05-11 8:41 ` Vinod Koul
2012-05-11 10:58 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FACF0DC.3050209@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.