All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging:iio:dummy: Remove outdated comment
Date: Fri, 11 May 2012 13:27:38 +0100	[thread overview]
Message-ID: <4FAD05BA.4090701@cam.ac.uk> (raw)
In-Reply-To: <1336737869-16186-1-git-send-email-lars@metafoo.de>

On 5/11/2012 1:04 PM, Lars-Peter Clausen wrote:
> iio_device_free has to be called regardless of whether the device has been
> registered or not when freeing it.
Good spot,
>
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>   drivers/staging/iio/iio_simple_dummy.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
> index 3b4513c..3104119 100644
> --- a/drivers/staging/iio/iio_simple_dummy.c
> +++ b/drivers/staging/iio/iio_simple_dummy.c
> @@ -470,8 +470,6 @@ error_unconfigure_buffer:
>   error_unregister_events:
>   	iio_simple_dummy_events_unregister(indio_dev);
>   error_free_device:
> -	/* Note free device should only be called, before registration
> -	 * has succeeded. */
>   	iio_device_free(indio_dev);
>   error_ret:
>   	return ret;


  reply	other threads:[~2012-05-11 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 12:04 [PATCH] staging:iio:dummy: Remove outdated comment Lars-Peter Clausen
2012-05-11 12:27 ` Jonathan Cameron [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-11 13:12 Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAD05BA.4090701@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.