From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSpKw-0005ZX-Rd for qemu-devel@nongnu.org; Fri, 11 May 2012 08:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSpKo-0003oJ-DM for qemu-devel@nongnu.org; Fri, 11 May 2012 08:52:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34954 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSpKo-0003oA-6z for qemu-devel@nongnu.org; Fri, 11 May 2012 08:52:38 -0400 Message-ID: <4FAD0B8C.8010609@suse.de> Date: Fri, 11 May 2012 14:52:28 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1336608892-30501-1-git-send-email-afaerber@suse.de> <1336608892-30501-35-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store ARMCPU in omap_mpu_state_s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org Am 10.05.2012 23:38, schrieb Peter Maydell: > On 10 May 2012 01:14, Andreas F=C3=A4rber wrote: >> Fix tab indentations of comments, add braces, use cpu_reset(). >> >> Signed-off-by: Andreas F=C3=A4rber >> --- >> hw/nseries.c | 6 +++--- >> hw/omap.h | 2 +- >> hw/omap1.c | 20 +++++++++++--------- >> hw/omap2.c | 8 ++++---- >> hw/omap_sx1.c | 2 +- >> hw/palm.c | 2 +- >> 6 files changed, 21 insertions(+), 19 deletions(-) >=20 > There are some structs here which use the name 'cpu' for > a 'struct omap_mpu_state_s *', which leads to ugliness > like s->cpu->cpu->env. (We shouldn't be trying to fix that > here, just a passing comment.) >=20 > Acked-by: Peter Maydell Thanks, applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Now that we have qom-next, we are no longer limited to the concept of self-contained series so I can try to turn that into s->mpu->cpu->env the weekend. Not perfect either, but better distinguishable. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg