From: Rich Johnston <rjohnston@sgi.com>
To: jeff.liu@oracle.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 2/2] xfstests: introduce 280 for SEEK_DATA/SEEK_HOLE copy check
Date: Fri, 11 May 2012 10:15:36 -0500 [thread overview]
Message-ID: <4FAD2D18.20403@sgi.com> (raw)
In-Reply-To: <4F2FE410.2040508@oracle.com>
On 02/06/2012 08:30 AM, Jeff Liu wrote:
> Introduce 280 for SEEK_DATA/SEEK_HOLE copy check.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>
> +static int
> +do_extent_copy(int src_fd, int dest_fd, off_t data_off, off_t hole_off)
> +{
...
> +
> + while (len> 0) {
> + memset(buf, 0, sizeof(buf));
> + ssize_t nr_read = read(src_fd, buf, BUF_SIZE);
#RCJ The memset above is unnecessary.
> +static int
> +copy_extents(int src_fd, int dest_fd, off_t src_total_size)
> +{
> + int ret = 0;
> + unsigned int i = 0;
...
> + ++i;
> + seek_start = hole_pos;
> + } while (seek_start< src_total_size);
#RCJ i is unused.
Other than the comments above, this version of the test looks good.
Reviewed-by: Rich Johnston<rjohnston@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-11 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 14:30 [PATCH v2 2/2] xfstests: introduce 280 for SEEK_DATA/SEEK_HOLE copy check Jeff Liu
2012-02-06 22:30 ` Mark Tinguely
2012-02-07 7:40 ` Jeff Liu
2012-02-07 14:17 ` Mark Tinguely
2012-02-08 8:55 ` Dave Chinner
2012-02-08 14:06 ` Jeff Liu
2012-02-08 22:44 ` Dave Chinner
2012-02-09 9:50 ` Jeff Liu
2012-05-11 15:15 ` Rich Johnston [this message]
2012-05-15 4:47 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAD2D18.20403@sgi.com \
--to=rjohnston@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.