Re: [PATCH v2] Add MIPS64R2 core support.

[Sergei Shtylyov <sshtylyov@mvista.com>]

On 05/11/2012 10:29 AM, Steven J. Hill wrote:

> From: "Steven J. Hill"<sjhill@mips.com>

    Looks like the subject is incorrect. Should be "Add MIPS 5KE support"?

> Signed-off-by: Leonid Yegoshin<yegoshin@mips.com>
> Signed-off-by: Steven J. Hill<sjhill@mips.com>
[...]

> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index d0570f4..862a9c3 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -282,6 +282,7 @@ config MIPS_MALTA
>   	select SYS_HAS_CPU_MIPS32_R1
>   	select SYS_HAS_CPU_MIPS32_R2
>   	select SYS_HAS_CPU_MIPS64_R1
> +	select SYS_HAS_CPU_MIPS64_R2
>   	select SYS_HAS_CPU_NEVADA
>   	select SYS_HAS_CPU_RM7000
>   	select SYS_HAS_EARLY_PRINTK
> @@ -2488,6 +2489,7 @@ config TRAD_SIGNALS
>   config MIPS32_COMPAT
>   	bool "Kernel support for Linux/MIPS 32-bit binary compatibility"
>   	depends on 64BIT
> +	default y if CPU_SUPPORTS_32BIT_KERNEL && SYS_SUPPORTS_32BIT_KERNEL
>   	help
>   	  Select this option if you want Linux/MIPS 32-bit binary
>   	  compatibility. Since all software available for Linux/MIPS is
> @@ -2507,6 +2509,7 @@ config SYSVIPC_COMPAT
>   config MIPS32_O32
>   	bool "Kernel support for o32 binaries"
>   	depends on MIPS32_COMPAT
> +	default y if CPU_SUPPORTS_32BIT_KERNEL&&  SYS_SUPPORTS_32BIT_KERNEL
>   	help
>   	  Select this option if you want to run o32 binaries.  These are pure
>   	  32-bit binaries as used by the 32-bit Linux/MIPS port.  Most of
> @@ -2525,6 +2528,10 @@ config MIPS32_N32
>
>   	  If unsure, say N.
>
> +comment "64bit kernel, but support of 32bit applications is disabled!"
> +	depends on 64BIT&&  !MIPS32_O32&&  !MIPS32_N32
> +	depends on CPU_SUPPORTS_32BIT_KERNEL&&  SYS_SUPPORTS_32BIT_KERNEL
> +

    The above looks like a material for separate patch...

WBR, Sergei