From: Ian Abbott <abbotti@mev.co.uk>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Ian Abbott <ian.abbott@mev.co.uk>,
"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: comedi: Add helper macro for comedi pci driver boilerplate
Date: Fri, 11 May 2012 18:32:16 +0100 [thread overview]
Message-ID: <4FAD4D20.1010302@mev.co.uk> (raw)
In-Reply-To: <201205111007.46754.hartleys@visionengravers.com>
On 2012-05-11 18:07, H Hartley Sweeten wrote:
> +int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
> + struct pci_driver *pci_driver)
> +{
> + int ret;
> +
> + ret = comedi_driver_register(comedi_driver);
> + if (ret< 0)
> + return ret;
> +
> + pci_driver->name = comedi_driver->driver_name;
I think it would be better if the driver modules that call this function
already had pci_driver->name initialized statically.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2012-05-11 17:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 17:07 [PATCH] staging: comedi: Add helper macro for comedi pci driver boilerplate H Hartley Sweeten
2012-05-11 17:32 ` Ian Abbott [this message]
2012-05-11 17:34 ` H Hartley Sweeten
2012-05-11 17:42 ` Ian Abbott
2012-05-11 17:50 ` H Hartley Sweeten
2012-05-11 18:14 ` Ian Abbott
2012-05-11 18:26 ` H Hartley Sweeten
2012-05-11 21:59 ` gregkh
2012-05-12 17:22 ` Ian Abbott
2012-05-11 17:59 ` Greg KH
2012-05-11 18:04 ` H Hartley Sweeten
2012-05-11 18:14 ` Ian Abbott
2012-05-11 18:18 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAD4D20.1010302@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.