From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: s/i915_wait_reqest/i915_wait_seqno/g
Date: Fri, 11 May 2012 19:56:42 -0300 [thread overview]
Message-ID: <4FAD992A.70402@linux.intel.com> (raw)
In-Reply-To: <1336769652-11740-4-git-send-email-ben@bwidawsk.net>
On 05/11/2012 05:54 PM, Ben Widawsky wrote:
> Wait request is poorly named IMO. After working with these functions for
> some time, I feel it's much clearer to name the functions more
> appropriately.
>
> Of course we must update the callers to use the new name as well.
>
> This leaves room within our namespace for a *real* wait request function
> at some point.
>
> Note to maintainer: this patch is optional.
>
> Signed-off-by: Ben Widawsky<ben@bwidawsk.net>
My only bikeshedding is to 's/wait_reqest/wait_request' in patch title :).
Eugeni
next prev parent reply other threads:[~2012-05-11 22:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 20:54 [PATCH 1/4 v4] drm/i915: timeout parameter for seqno wait Ben Widawsky
2012-05-11 20:54 ` [PATCH 2/4 v3] drm/i915: improve i915_wait_request_begin trace Ben Widawsky
2012-05-11 20:54 ` [PATCH 3/4 v6] drm/i915: wait render timeout ioctl Ben Widawsky
2012-05-11 23:09 ` Eugeni Dodonov
2012-05-12 21:07 ` Ben Widawsky
2012-05-11 20:54 ` [PATCH 4/4] drm/i915: s/i915_wait_reqest/i915_wait_seqno/g Ben Widawsky
2012-05-11 22:56 ` Eugeni Dodonov [this message]
2012-05-12 21:20 ` Ben Widawsky
2012-05-11 20:54 ` [PATCH] intel: add a timed wait function Ben Widawsky
2012-05-11 20:54 ` [PATCH] tests/wait render timeout test Ben Widawsky
2012-05-11 23:09 ` [PATCH 1/4 v4] drm/i915: timeout parameter for seqno wait Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAD992A.70402@linux.intel.com \
--to=eugeni.dodonov@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.