From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Subject: [PATCH] qemu msi/msix: added functions to API to set up message address and data Date: Sat, 12 May 2012 16:48:40 +1000 Message-ID: <4FAE07C8.7000502@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: Alex Williamson , Benjamin Herrenschmidt , David Gibson , anthony@codemonkey.ws, Alex Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org To: qemu-devel@nongnu.org Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:55613 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973Ab2ELGso (ORCPT ); Sat, 12 May 2012 02:48:44 -0400 Received: by dady13 with SMTP id y13so3927898dad.19 for ; Fri, 11 May 2012 23:48:43 -0700 (PDT) Sender: kvm-owner@vger.kernel.org List-ID: Added msi_set_address_data and msix_set_address_data in order to support sPAPR-specific implementation of MSI/MSIX configuration mechanism. POWER guest does not initialize these fields, it expects a supervisor to get them initialized. Required for VFIO on POWER. Signed-off-by: Alexey Kardashevskiy --- hw/msi.c | 14 ++++++++++++++ hw/msi.h | 1 + hw/msix.c | 10 ++++++++++ hw/msix.h | 3 +++ 4 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index 5d6ceb6..124878a 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -358,3 +358,17 @@ unsigned int msi_nr_vectors_allocated(const PCIDevice *dev) uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev)); return msi_nr_vectors(flags); } + +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data) +{ + uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev)); + bool msi64bit = flags & PCI_MSI_FLAGS_64BIT; + + if (msi64bit) { + pci_set_quad(dev->config + msi_address_lo_off(dev), address); + } else { + pci_set_long(dev->config + msi_address_lo_off(dev), address); + } + pci_set_word(dev->config + msi_data_off(dev, msi64bit), data); +} + diff --git a/hw/msi.h b/hw/msi.h index 3040bb0..0acf434 100644 --- a/hw/msi.h +++ b/hw/msi.h @@ -34,6 +34,7 @@ void msi_reset(PCIDevice *dev); void msi_notify(PCIDevice *dev, unsigned int vector); void msi_write_config(PCIDevice *dev, uint32_t addr, uint32_t val, int len); unsigned int msi_nr_vectors_allocated(const PCIDevice *dev); +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data); static inline bool msi_present(const PCIDevice *dev) { diff --git a/hw/msix.c b/hw/msix.c index 3835eaa..c57c299 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -414,3 +414,13 @@ void msix_unuse_all_vectors(PCIDevice *dev) return; msix_free_irq_entries(dev); } + +void msix_set_address_data(PCIDevice *dev, int vector, + uint64_t address, uint32_t data) +{ + uint8_t *table_entry = dev->msix_table_page + vector * PCI_MSIX_ENTRY_SIZE; + pci_set_quad(table_entry + PCI_MSIX_ENTRY_LOWER_ADDR, address); + pci_set_long(table_entry + PCI_MSIX_ENTRY_DATA, data); + table_entry[PCI_MSIX_ENTRY_VECTOR_CTRL] &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT; +} + diff --git a/hw/msix.h b/hw/msix.h index 5aba22b..e6bb696 100644 --- a/hw/msix.h +++ b/hw/msix.h @@ -29,4 +29,7 @@ void msix_notify(PCIDevice *dev, unsigned vector); void msix_reset(PCIDevice *dev); +void msix_set_address_data(PCIDevice *dev, int vector, + uint64_t address, uint32_t data); + #endif -- Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ST68G-0005mK-Pv for qemu-devel@nongnu.org; Sat, 12 May 2012 02:48:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ST68E-00058X-VD for qemu-devel@nongnu.org; Sat, 12 May 2012 02:48:48 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:50495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ST68E-00058P-Ob for qemu-devel@nongnu.org; Sat, 12 May 2012 02:48:46 -0400 Received: by dadv2 with SMTP id v2so5429804dad.4 for ; Fri, 11 May 2012 23:48:43 -0700 (PDT) Message-ID: <4FAE07C8.7000502@ozlabs.ru> Date: Sat, 12 May 2012 16:48:40 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] qemu msi/msix: added functions to API to set up message address and data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Alex Graf , Alex Williamson , anthony@codemonkey.ws, David Gibson Added msi_set_address_data and msix_set_address_data in order to support sPAPR-specific implementation of MSI/MSIX configuration mechanism. POWER guest does not initialize these fields, it expects a supervisor to get them initialized. Required for VFIO on POWER. Signed-off-by: Alexey Kardashevskiy --- hw/msi.c | 14 ++++++++++++++ hw/msi.h | 1 + hw/msix.c | 10 ++++++++++ hw/msix.h | 3 +++ 4 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index 5d6ceb6..124878a 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -358,3 +358,17 @@ unsigned int msi_nr_vectors_allocated(const PCIDevice *dev) uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev)); return msi_nr_vectors(flags); } + +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data) +{ + uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev)); + bool msi64bit = flags & PCI_MSI_FLAGS_64BIT; + + if (msi64bit) { + pci_set_quad(dev->config + msi_address_lo_off(dev), address); + } else { + pci_set_long(dev->config + msi_address_lo_off(dev), address); + } + pci_set_word(dev->config + msi_data_off(dev, msi64bit), data); +} + diff --git a/hw/msi.h b/hw/msi.h index 3040bb0..0acf434 100644 --- a/hw/msi.h +++ b/hw/msi.h @@ -34,6 +34,7 @@ void msi_reset(PCIDevice *dev); void msi_notify(PCIDevice *dev, unsigned int vector); void msi_write_config(PCIDevice *dev, uint32_t addr, uint32_t val, int len); unsigned int msi_nr_vectors_allocated(const PCIDevice *dev); +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data); static inline bool msi_present(const PCIDevice *dev) { diff --git a/hw/msix.c b/hw/msix.c index 3835eaa..c57c299 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -414,3 +414,13 @@ void msix_unuse_all_vectors(PCIDevice *dev) return; msix_free_irq_entries(dev); } + +void msix_set_address_data(PCIDevice *dev, int vector, + uint64_t address, uint32_t data) +{ + uint8_t *table_entry = dev->msix_table_page + vector * PCI_MSIX_ENTRY_SIZE; + pci_set_quad(table_entry + PCI_MSIX_ENTRY_LOWER_ADDR, address); + pci_set_long(table_entry + PCI_MSIX_ENTRY_DATA, data); + table_entry[PCI_MSIX_ENTRY_VECTOR_CTRL] &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT; +} + diff --git a/hw/msix.h b/hw/msix.h index 5aba22b..e6bb696 100644 --- a/hw/msix.h +++ b/hw/msix.h @@ -29,4 +29,7 @@ void msix_notify(PCIDevice *dev, unsigned vector); void msix_reset(PCIDevice *dev); +void msix_set_address_data(PCIDevice *dev, int vector, + uint64_t address, uint32_t data); + #endif -- Alexey