Re: [PATCH v4 3/7] x86/flush_tlb: try flush_tlb_single one by one in flush_tlb_range

[Alex Shi <alex.shi@intel.com>]

On 05/10/2012 05:04 PM, Alex Shi wrote:

> 
>>> +
>>> +#define FLUSHALL_BAR	16
>>> +
>>
>> Btw, you can save a bunch of indenting on this function, let me add
>> the final version here from the whole patchset so I can comment on it
>> easier:
>>
>>> void __flush_tlb_range(struct mm_struct *mm, unsigned long start,
>>>                                 unsigned long end, unsigned long vmflag)
>>> {
>>>         preempt_disable();
>>>         if (current->active_mm == mm) {
>>
>> 	if (current->active_mm != mm)
>> 		goto flush_all;
>>
>> Now this whole piece below can move one indentation level to the left.


that is helpful and not imply logical too much.

>>
>> Then you can do:
>>
>> 	if (!current->mm)
>> 		goto leave;
>>
>> and add the "leave" label below.


I tried this, found too many goto and label is worse than line breaking. :(

>>
>> Now you're saving yet another indentation level, bringing the meat of
>> the function at 1st indentation level, which is cool and gives you much
>> more room so that you don't have to linebreak longer statements.
>>
> 
> 
> sure, thanks! :)