All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
	Ian Abbott <ian.abbott@mev.co.uk>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: comedi: Add helper macro for comedi pci driver boilerplate
Date: Sat, 12 May 2012 18:22:33 +0100	[thread overview]
Message-ID: <4FAE9C59.4030108@mev.co.uk> (raw)
In-Reply-To: <20120511215943.GA27371@kroah.com>

On 11/05/2012 22:59, gregkh@linuxfoundation.org wrote:
> On Fri, May 11, 2012 at 01:26:37PM -0500, H Hartley Sweeten wrote:
>> How about doing this in the register function:
>>
>> 	If (!pci_driver->name)
>> 		pci_driver->name = comedi_driver->driver_name;
>>
>> This way all the drivers that still need to be refactored will still work.
>>
>> After all the drivers have been updated, those two lines can be
>> removed.
>>
>> So we have this patch and one big patch updating all the refactored
>> drivers. Some number of patches refactoring the remaining drivers
>> and using the module_comedi_pci_driver macro. Then one last
>> patch removing the check above.
>>
>> How does that sound?
>
> That sounds reasonable to me.

Sounds reasonable to me too.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

  reply	other threads:[~2012-05-12 17:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 17:07 [PATCH] staging: comedi: Add helper macro for comedi pci driver boilerplate H Hartley Sweeten
2012-05-11 17:32 ` Ian Abbott
2012-05-11 17:34   ` H Hartley Sweeten
2012-05-11 17:42     ` Ian Abbott
2012-05-11 17:50       ` H Hartley Sweeten
2012-05-11 18:14         ` Ian Abbott
2012-05-11 18:26           ` H Hartley Sweeten
2012-05-11 21:59             ` gregkh
2012-05-12 17:22               ` Ian Abbott [this message]
2012-05-11 17:59 ` Greg KH
2012-05-11 18:04   ` H Hartley Sweeten
2012-05-11 18:14     ` Ian Abbott
2012-05-11 18:18       ` H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAE9C59.4030108@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hartleys@visionengravers.com \
    --cc=ian.abbott@mev.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.