From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39185)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1STJUW-0000ax-7a
	for qemu-devel@nongnu.org; Sat, 12 May 2012 17:04:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1STJUU-0007qN-At
	for qemu-devel@nongnu.org; Sat, 12 May 2012 17:04:39 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:49123)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1STJUU-0007o4-4a
	for qemu-devel@nongnu.org; Sat, 12 May 2012 17:04:38 -0400
Message-ID: <4FAED063.3070608@weilnetz.de>
Date: Sat, 12 May 2012 23:04:35 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <CAAu8pHvAHp=RKNydq88FH+VVH7WLHrv6SmJgVKSO6St-vC4JvQ@mail.gmail.com>
In-Reply-To: <CAAu8pHvAHp=RKNydq88FH+VVH7WLHrv6SmJgVKSO6St-vC4JvQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: add missing 'static'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

Am 12.05.2012 21:47, schrieb Blue Swirl:
> There are no outside references to virtio_portio.
> Add missing 'static' specifier.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> hw/virtio-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index 4a4413d..8a931ce 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -491,7 +491,7 @@ static void virtio_pci_config_writel(void *opaque,
> uint32_t addr, uint32_t val)

line was wrapped

> virtio_config_writel(proxy->vdev, addr, val);
> }
>
> -const MemoryRegionPortio virtio_portio[] = {
> +static const MemoryRegionPortio virtio_portio[] = {
> { 0, 0x10000, 1, .write = virtio_pci_config_writeb, },
> { 0, 0x10000, 2, .write = virtio_pci_config_writew, },
> { 0, 0x10000, 4, .write = virtio_pci_config_writel, },

terminating "---" and git version missing


Reviewed-by: Stefan Weil <sw@weilnetz.de>

The patch is fine, but your mailer reformats the patch:
it cannot by applied with "git am" without manual corrections.

Regards,
Stefan W.